Contribute to the DSpace Development Fund
The newly established DSpace Development Fund supports the development of new features prioritized by DSpace Governance. For a list of planned features see the fund wiki page.
Date
Discussion (combined Angular UI & REST meeting)
Attendees
- Andrea Bollini (4Science)
- Art Lowel (Atmire)
- Patrick Trottier
- Tim Donohue
- Mark H. Wood
- Terrence W Brady
- Pascal-Nicolas Becker
Location: DSpace Meeting Room
Notes
- General Updates
- Planning Spreadsheet: https://docs.google.com/spreadsheets/d/18brPF7cZy_UKyj97Ta44UJg5Z8OwJGi7PLoPJVz-g3g/edit?usp=sharing
- Latest status is still there
- Code Style work by Tim
- Documentation at: Code Style Guide
- Code Style configuration in this small PR: https://github.com/DSpace/DSpace/pull/1895
- Code Style fixes for `master` in this large PR: https://github.com/DSpace/DSpace/pull/1952
- Planning Spreadsheet: https://docs.google.com/spreadsheets/d/18brPF7cZy_UKyj97Ta44UJg5Z8OwJGi7PLoPJVz-g3g/edit?usp=sharing
- Angular UI Team updates (via Art)
Question about whether Angular code also has a Code Style
- It does, it's handled/validated by "lint". Specifically this config file: https://github.com/DSpace/dspace-angular/blob/master/tslint.json
- dspace-angular follows the official Angular Style Guide at https://angular.io/guide/styleguide
Angular 5 upgrade complete and merged:
- However, a new bug just discovered with turning off server side rendering
- https://github.com/DSpace/dspace-angular/issues/226
- Fix at: https://github.com/DSpace/dspace-angular/pull/227
- ACTION (Tim): Review and test.
- Lotte has a PR for search page truncation: https://github.com/DSpace/dspace-angular/pull/221
- Ready for review, testing & merger
- ACTION (anyone): Review & test.
- Lotte has moved on to working on Bootstrap 4 upgrade: https://github.com/DSpace/dspace-angular/issues/215
- Art is still working on the Search UI. He was pulled onto other projects briefly, so things got delayed. He's now getting back to it.
- New bugs:
- Search broken when Javascript disabled: https://github.com/DSpace/dspace-angular/issues/222 (Lotte is looking into it)
- Empty REST Response issue: https://github.com/DSpace/dspace-angular/issues/224
- Giuseppe has tested this and it seems to be solved on the Angular side once we next upgrade Angular (to latest minor bug fix)
- However, we need a REST API ticket to log the 204 response improvement
- ACTION (Andrea): Create a REST API ticket to note that we need 204 responses for empty bodies (Done: )
- Switch to using Angular CLI. Needs volunteer
- Giuseppe is working on Authentication
- Authentication from Angular UI works. Adding tests now. PR will be coming soon
- Notes that token expiration (in Angular) seems to be an issue at times. Angular tries to use an expired token at times
- Working on a fix / suggestion that will be shared
- REST API Updates (via Andrea)
- Lots of 4Science developers were out sick this week. Not as much progress to share
- 4Science team is working to finalize the REST Contract for Workflow functionality. Should be ready to share new week, hopefully.
- Merged re-enabling of maven-enforcer-plugin (from Mark W): https://github.com/DSpace/DSpace/pull/1936
- Prior to meeting Tom Desair shared his updates on Slack
- I was planning to attend the DSpace 7 meeting but I have to pickup my daughter who got sick today (nothing serious). We’re still working on getting the Spring Security PR and Spring REST docs PR backup up and running after the latest changes on master.
- Spring Security PR is https://github.com/DSpace/DSpace/pull/1916
- Spring REST docs PR is https://github.com/DSpace/DSpace/pull/1915
- Code Style work from Tim
- Documentation at: Code Style Guide
- Code Style configuration in this small PR: https://github.com/DSpace/DSpace/pull/1895
- Code Style fixes for `master` in this large PR: https://github.com/DSpace/DSpace/pull/1952
- All agree this is a good effort, and should be moved forward quickly.
- However, Andrea notes that there's a few minor PRs he'd like to see merged into "master" (as they are nearly ready to go) prior to the massive Code Style PR (#1952)
- https://github.com/DSpace/DSpace/pull/1898
- https://github.com/DSpace/DSpace/pull/1939
- https://github.com/DSpace/DSpace/pull/1927
- ACTION (Andrea): He will work to review / merge these three PRs into "master". Once complete, Tim will update the Code Style PR and get ready for immediate merger.
- Next Meeting will be Thurs, Feb 22 at 15:00UTC in DSpace Meeting Room
Overview
Content Tools