Contribute to the DSpace Development Fund
The newly established DSpace Development Fund supports the development of new features prioritized by DSpace Governance. For a list of planned features see the fund wiki page.
Date
from 14:00-14:15 UTC
Location: DSpace Meeting Room
Agenda
Short meeting only to discuss angular pr/264
- There was no rest section
Attendees
Notes
- Statuscode OK
- https://github.com/DSpace/dspace-angular/pull/264/files/2ffbdf942c574d76fcc8b41e2781df7a4150a21f#r198514562
- Why is the status code ever ‘OK’ for SSR?
- when the request is made from the javascript server-side, you get
OK
from the REST server, for requests about the config service. - We'll leave the handler for OK in the angular code for now, Giuseppe Digilio (4Science) will create a REST api ticket for this, and we'll remove it once that's fixed.
- when the request is made from the javascript server-side, you get
- The big switch
- https://github.com/DSpace/dspace-angular/pull/264/files/2ffbdf942c574d76fcc8b41e2781df7a4150a21f#diff-2298edd850796a22bfa1da569fccc236
- Giuseppe Digilio (4Science) says this code comes from the ng-dynamic-forms library. It was only added to dspace to extend it (add additional form controls)
- In the Angular 6 version of the library that switch has been refactored in the way that was suggested is the review comments
- The angular 6 way will also make it no longer necessary to include the template in the dspace codebase, we can create new components using annotations instead
- Fixing this now would be a lot of work, that will be removed after the update
- So we'll leave out the refactor for now and discuss the angular 6 update in the sprint kickoff meeting
- https://github.com/DSpace/dspace-angular/pull/264/files/2ffbdf942c574d76fcc8b41e2781df7a4150a21f#diff-2298edd850796a22bfa1da569fccc236
- The Next Meeting will be the kickoff meeting for sprint #2 on Monday, July 9 at 14:00UTC(10:00am EDT) in DSpace Meeting Room
Overview
Content Tools