This Confluence wiki site, maintained by DuraSpace prior to the recent merger with LYRASIS, will transition from the duraspace.org domain to the lyrasis.org domain on Saturday, Nov 16 beginning at approximately 7pm ET. A period of downtime of 2-3 hours is expected. After the transition, this wiki will be available at https://wiki.lyrasis.org/. All links to duraspace.org wiki pages will be redirected to the correct lyrasis.org URL. If you have questions prior to or following the transition please contact: wikihelp@lyrasis.org.

Page tree
Skip to end of metadata
Go to start of metadata

Date

 from 15:00-16:00 UTC  (At end of March, this meeting will switch to 14:00 UTC)

Location: https://duraspace.zoom.us/my/dspace (Meeting ID: 502 527 3040).

Agenda

  • (15 mins) Developer Stand Up - Developers give brief updates on their effort (or their team's effort).

    • Update/see "Current Work" section below based on your status. Please feel free to update prior to meeting.
    • Please highlight any new work (needing reviews/testing), any blockers (for you), and any discussion topics you may have.
  • (30 mins) General Discussion Topics
    1. Solr upgrade is ready to merge (already at +2).  Is everyone ready? https://github.com/DSpace/DSpace/pull/2058
      1. This will affect developers (everyone needs to install Solr)
      2. This will also affect the demo REST API (next time it is updated)
    2. Finalizing the Workflow REST Endpoint PR: https://github.com/DSpace/DSpace/pull/2312/  Several key changes to the existing Discovery/Solr functionality.
      1. Creates a new interface "BrowsableObject" to represent anything indexable by Discovery/Solr (this used to require an object being an official `DSpaceObject`)
        1. Possibly rename to "IndexableObject" (i.e. it's an object that can be indexed)
      2. Adds new Constants for object types "WORKSPACEITEM", "WORKFLOWITEM", "WORKFLOW_POOL", "WORKFLOW_CLAIMED".  These are NOT DSpaceObjects, but are new BrowsableObjects (as they will be indexed in Discovery for the MyDSpace & Workflow user interface)
        1. Possibly rename "WORKFLOW_POOL" to "TASK_POOL" and "WORKFLOW_CLAIMED" to "TASK_CLAIMED"
        2. We don't need to index the ITEM individually when indexing the WORKSPACEITEM or WORKFLOWITEM (Andrea believes this to be true)
      3. Changes the Discovery REST response format slightly – it no longer returns "dspaceObject", but now returns "resultObject" (as not all results are DSpaceObjects)
    3. (tentative. lower priority) Edit Homepage News: https://github.com/DSpace/Rest7Contract/pull/45
      1. Reporting back on implementation suggestions/ideas.  Do we implement as metadata on the Site object (similar to Community/Collection news sections)?
    4. (add a discussion topic)
  • (15 mins) Planning for next week

Attendees

Current Work

Legend for status icons

(blue star) = Highest Priority tasks (please prioritize these reviews/tasks over others). Currently this lists tasks/features that need to be completed for Preview Release.

(error) = review done (this week), changes were requested.

(tick) = review done, approved.

(warning) = review done, merge conflict or other minor changes requests

Tickets / PRs In Progress

  1. (Angular) Adding Accessibility via Travis CI  https://github.com/DSpace/dspace-angular/pull/356 (work in progress) (Lower priority)
  2. (blue star) (Angular) MyDSpace UI (work in progress) (Timeline: Should be ready by Feb 28, delayed  5th Marchdelayed  12th March due to sub optimal Search implementation, need to run against the updated MyDSpace REST API PR - Blocked until discussion around the MyDSpace Endpoint is solved see 2312 and  https://github.com/4Science/DSpace/pull/65)
  3. (REST Contract) Edit Homepage news: https://github.com/DSpace/Rest7Contract/pull/45 (Ben Bosman  - has outstanding questions/comments) (Lower priority)
  4. (blue star) (REST) MyDSpace Endpoint (Andrea Bollini (4Science) - EARLY Reviews Needed. Reviewers: Ben BosmanTim Donohue  (everything in place, first review comments answered, ITs provided on the 3rd March ) on the 4Science repo against the 2312 PR https://github.com/4Science/DSpace/pull/65
  5. (REST) Updating Owning Collections: https://github.com/DSpace/DSpace/pull/2283 (Kevin Van de Velde (Atmire)  - changes requested. Implementation doesn't align with contract) (Timeline: Should be ready a week after the entities are merged)
  6. (REST) Item Mapper functionality: https://github.com/DSpace/DSpace/pull/2282  (Kevin Van de Velde (Atmire)  - changes requested. Implementation doesn't align with contract) (Timeline: Should be ready a week after the entities are merged)
  7. (blue star) Configurable Entities PRs for Angular & REST (coming soon from DSpace 7 Entities Working Group)
    1. https://github.com/DSpace/DSpace/pull/2331 (blocking PR to master)
    2. https://github.com/DSpace/dspace-angular/pull/354 (blocking PR to master)

PRs Needing Review

  1. (warning) (REST Contract) Group and eperson management: https://github.com/DSpace/Rest7Contract/pull/41 (Waiting on updates from Ben Bosman )
  2. (attenzione) (blue star) (REST) Workflow Endpoint: https://github.com/DSpace/DSpace/pull/2312 (Tim Donohue , Ben Bosman Re-reviewed and additional feedback added., All change requests implemented - answers provided also for latest feedbacks) 
  3. (warning) (REST) EPerson profile PATCH functionality : https://github.com/DSpace/DSpace/pull/2257 (Andrea Bollini (4Science) , Tim Donohue .  This PR currently has merge conflicts & has outstanding feedback from Tom Desair)
  4. (blue star) (Angular) Submission implementation: https://github.com/DSpace/dspace-angular/pull/279  (Art Lowel (Atmire) , Paulo Graça - reviewed, Tim Donohue . This PR has outstanding feedback (namely code comments) to be applied.)
  5. (warning) (Angular) Transfer to .po message format - Initial PR: https://github.com/DSpace/dspace-angular/pull/366 (Paulo Graça - changes requested, Tim Donohue , Art Lowel (Atmire)  - requested updates. Currently failing build.)
  6. (warning) (Angular) Context sensitive admin menus  https://github.com/DSpace/dspace-angular/pull/367 (Paulo Graça - issue reported & response/fix made by Lotte, Tim Donohue - approved)
  7. (Backend) One Webapp Backend - Initial PR: https://github.com/DSpace/DSpace/pull/2265 (Ben Bosman , Mark H. Wood )
    1. This PR will have a followup PR to rename the "dspace-spring-rest" webapp to "dspace-server" and update all URL configurations
  8. (Backend) Upgrading Solr Server for DSpace - Initial PR: https://github.com/DSpace/DSpace/pull/2058 (Terrence W Brady , Kim Shepherd , Art Lowel (Atmire))
    1. Might have an impact on MyDSpace PR (See "In Progress" section)?
    2. Docker changes to merge after this PR is merged: https://github.com/DSpace-Labs/DSpace-Docker-Images/pull/96
  9. (blue star) (Docker) https://github.com/DSpace-Labs/DSpace-Docker-Images/pull/95 (Art Lowel (Atmire))
  10. https://github.com/DSpace/dspace-angular/issues/368 (Andrea Bollini (4Science)Giuseppe Digilio (4Science)Tim DonohueBen Bosman)

    1. Potentially a discussion item for next week.

PRs Merged this week!

  1. (tick) (REST) Metadata PATCH support: https://github.com/DSpace/DSpace/pull/2313 
  2. (tick) (REST) Fix bug where CORS Headers missing when Exception thrown: https://github.com/DSpace/DSpace/pull/2208
  3. (tick) (Angular) Browse by date and Starts-With component: https://github.com/DSpace/dspace-angular/pull/364
    1. Outstanding usability issues logged as tickets #369 and #370, and the related REST API bug logged at DS-4186

BLOCKED

  1. (Angular) Move Item Component: https://github.com/DSpace/dspace-angular/pull/335
    1. Blocked by DSpace PR#2283
  2. (Angular) Item-Collection Mapper:  https://github.com/DSpace/dspace-angular/pull/348
    1. Blocked by DSpace PR#2282

Delayed

  1. (REST) Scripts & Processes endpoint: https://github.com/DSpace/Rest7Contract/pull/17
  2. Concurrency in DSpace 7 (or 8).  What do we want to do when multiple editors are editing the same object?  Needs further analysis regarding implementation details
    1. We've decided (in meeting on March 7, 2019) to use ETags to implement concurrency. REST Contract notes on ETags: https://github.com/DSpace/Rest7Contract#etags--conditional-headers
    2. ETags only update of the two fields match. If someone edits first, your edit would fail and you would get a fail response (422?)
    3. ETags seems to have broader support in other REST APIs.  Recommended also by both Art and Andrea.

Priorities for Preview Release

As discussed in previous DSpace 7 meetings, our DSpace 7 Preview release is aimed for end of March, followed by a Beta in May (before OR2019).  The top priorities for the Preview Release are (in this order):

  1. Submission & Workflow UI / backend
  2. Configurable Entities (from DSpace 7 Entities Working Group)
  3. Upgrading Solr Server for DSpace (not required for Preview, as there's no user facing features. However, the earlier we feel comfortable merging this effort the better)

Notes