Page History
...
Andrea Bollini (4Science) (only attended first part of mtg)
- Mark H. Wood
- Giuseppe Digilio (4Science)
- Ben Bosman
- Pascal-Nicolas Becker (did not attend)
- Chris Wilper
- Terrence W Brady
- Pablo Prieto
Notes
(Notes below copied from last meeting. Details will be updated during this meeting.)
- General Updates (Tim)
- OR2019 Proposal Planning
- Tim will create a wiki page for DSpace 7 OR2019. Everyone should add/link your proposals there.
- Assigned a lead for each proposal (see list above, until Wiki page is created)
- Angular Team Updates (Art)
- Merged PRs:
- In Progress tickets / PRs:
- Tickets / PRs requiring review:
- https://github.com/DSpace/dspace-angular/pull/335349 (May have more updates once the REST Contract is finalizedHighest Priority)
- https://github.com/DSpace/dspace-angular/pull/337 (On hold until after Preview: Restructures imports. Nice idea, but likely needs rescheduling until we can enforce or reschedule it350 (based on same branch as 349)
- https://github.com/DSpace/dspace-angular/pull/330 Several small PRs from Bram (reviewed by Art, waiting on updates348 (based on same branch as 348)
- https://github.com/DSpace/dspace-angular/pull/329 347 (end goal to support PATCHes of Metadata)
- https://github.com/DSpace/dspace-angular/pull/324342 (Item Actions - NEED Demo REST API Update)
- https://github.com/DSpace/dspace-angular/pull/335 (BLOCKED by REST Contract discussions about Move Item)
- Submission/Workflow PR: https://github.com/DSpace/dspace-angular/pull/279
- Giuseppe says this wIll be ready in the next week or so. Goal is still to have done in December
- Submission/Workflow PR: https://github.com/DSpace/dspace-angular/pull/338279
- Giuseppe says this wIll be ready for final review by Monday, January 14. He will ping us
- ACTION: Anyone who has added past comments (that are now fixed), please go in and resolve your past comments once you've verified the fix. That'll help us figure out what is outstanding (if anything)
- Design at Menu Mockups
- REST Team Updates
- Open PRs: https://github.com/DSpace/DSpace/pulls?q=is%3Apr+is%3Aopen+label%3A%22REST+API+v7%22+sort%3Aupdated-desc
- Merged PRs:
- In Progress tickets / PRs:
- Tickets / PRs requiring review:
- REST Contract tickets blocking other work (High Priority to get unblocked)
- Request to use Spring Data REST "text-uri/list" to manage links between objects (Resources: https://
- REST Contract tickets blocking other work (High Priority to get unblocked)
github.com/4Science/DSpace/pull/37 (Still waiting on Andrea to find time to create a PR from this- After that PR, we also will have a MyDSpace PR to complete the REST API side of Submission & Workflow
- DSpace
- 2129 (More feedback to take into account. Nearly ready to go.)
- DSpace
- 2257 (Feedback given by Andrea. Needs updates from PR creator)Contract Tickets needs finalization:
- 33 (Needs updates as the concept of "owningCommunity" has no meaning for Communities/Collections)
- 41
- ACTION: Tim Donohue will reach out to Andrea Bollini (4Science)to understand whether we can move forward with parameters for now, and update this contract/implementation later. It's unclear to the team why these three tickets are blocked for Spring Data REST alignment, while others that involve links/associations (e.g. PR#37 (Item CRUD) and PR#38 (Metadata Registry)) were approved.
- Should we consider fixing all these implementations to better align with Spring Data REST recommendations (perhaps in a future Ticket/PR)?
- ACTION: We need to better document the requirements / best practices for our REST API. Currently alignment with Spring Data REST is not mentioned in our REST Contract README
See also this comment- DSpace
- pull/2277/files#diff-601b55536dca517a800fcafc9026a3ebR70
- Updating Collection/Community contracts (Requires re-review)
- Feedback from Andrea, but needs re-review
- https://github.com/DSpace/Rest7Contract/pull/
34 (Needs examples from REST Contract or Integration Tests. Ben is unclear of request from Andrea Bollini (4Science) )- Metadata as a Map (Requires re-review)
- REST Contract: https://github.com/DSpace/Rest7Contract/pull/
35 (Comments need clarification. Ben is unclear of request from - 39
- Contract has feedback from Andrea & Approved by Tim. Waiting for rereview from Andrea Bollini (4Science)
)- JIRA:
Jira server DuraSpace JIRA serverId c815ca92-fd23-34c2-8fe3-956808caf8c5 key DS-4107 - REST Implementation: https://github.com/DSpace/
- JIRA:
Rest7Contract- 17 (Needs final comments, however this is scheduled for BETA. So, not as high priority)
- 2287
- Angular Updates: https://github.com/DSpace/dspace-angular/pull/347
- Metadata Registry (8.1) - Needs Reviews
- JIRA:
Jira server DuraSpace JIRA serverId c815ca92-fd23-34c2-8fe3-956808caf8c5 key DS-4109 - (Merged) Contract: https://github.com/DSpace/Rest7Contract/pull/38
- REST: https://github.com/DSpace/DSpace/pull/2291
- JIRA:
- Administrative Edit Item (metadata, bitstreams, assign roles) (7.13) - Needs Reviews
- JIRA:
Jira server DuraSpace JIRA serverId c815ca92-fd23-34c2-8fe3-956808caf8c5 key DS-4108 - (Merged) Contract: https://github.com/DSpace/Rest7Contract/pull/37
- REST: https://github.com/DSpace/DSpace/pull/2290
- JIRA:
- Tim asked about whether Admins should be able to create Items directly (bypassing workflow) via POST requests?
- Others note this seems to already be possible in the Java API (via bulk CSV import?)
- However, all agree that it's not a high priority
- If this turns out to be complicated, we should drop POST from this endpoint. If it's easy enough, we can implement, but it should be restricted to Admins
- Also POST needs to somehow take in the Collection, as you cannot create an Item without a Collection
- OR2019 DSpace 7 Presentations
- (Did not discuss in detail) Discussion of EPerson Deletion (from Pascal-Nicolas Becker Tim again asked that all write in your feedback on DS-4306 ticket)
- Ticket:
Jira server DuraSpace JIRA serverId c815ca92-fd23-34c2-8fe3-956808caf8c5 key DS-4036 - PR: https://github.com/DSpace/DSpace/pull/2229
- Some disagreement over whether the approach of "null" EPersons is the proper one, or if it will turn into requiring more code than a "ghost user" would.
- ACTION: ALL will add comments/thoughts to DS-4036 so we can finalize a decision on whether "null" EPersons are OK or not.
- Ticket:
- (Did not discuss) DSpace 7 installation/customization process.
- Updated PR could use more eyes: https://github.com/DSpace/DSpace/pull/2265
- See also early docs at: DSpace Backend as One Webapp
- Development planning/updates in Development Planning Spreadsheet.
- The Next Meeting will be Thurs, Jan 17 at 15:00UTC (10:00am EST) in DSpace Meeting Room
Overview
Content Tools