...
- Danny Bernstein
- Peter Eichman
- Bethany Seeger
- Jared Whiklo
- Andrew Woods
- Kevin Ford
- Michael Durbin
- Ben Pennell
- Aaron Birkland
Agenda
Announcements
- Sprint 2 Strategy and Goals
- Release candidate
- Vagrant
- Camel toolbox
- java client
- Release candidate
Open questions:
Jira server DuraSpace JIRA serverId c815ca92-fd23-34c2-8fe3-956808caf8c5 key FCREPO-2730 - 4 Integration tests in FedoraLdpIT are breaking due to a 500 Error.
The cause of the 500 is
Code Block javax.jcr.RepositoryException: The session with an ID of '060742fc6' has been closed and can no longer be used.
- It appears to be an OSX 10.13.x issue : Jared Whiklo, Peter Eichman, and Danny Bernstein have reproduced.
- Danny Bernstein confirmed It was not a problem for OSX 10.10.5
- Any ideas of how to solve it?
- If we can't resolve it, what are our options?
- Leave the tests in place - and document the problem in the README.
- @Ignore the tests until we can sort out the issue or it sorts itself out (OS fix)
- ?
- Data URIs in the constrainedBy link header
- Proposal: Remove and use standard URIs instead like we do with all other constraints.
- Prefer headers on Mementos: https://github.com/fcrepo4/fcrepo4/pull/1420
- Question1: Should the original resource return <> a ldp:Container and <> a ldp:RDFSource when omitting server managed triples (currently these are being omitted in OriginalResource but not the Memento)
- Question2: How should fedora respond to requests to Prefer omit
- What would a use case for omitting server managed triples in memento?
- Proposal 1: Mementos should behave like the original resource
- Rationale?
- Action: based on the answer to Question1 either omit the ldp types from memento or add them to the original resource response
- Proposal 2: Mementos should not respond to Prefer omit
- Rationale?
- Proposal 3: ?
- All AuthZ tests assume literal agent values
- What is the best way to fix this problem?
<your agenda item here>
Please squash a bug!
Expand Jira server DuraSpace JIRA columns key,summary,type,created,updated,due,assignee,reporter,priority,status,resolution maximumIssues 20 jqlQuery filter=13122 serverId c815ca92-fd23-34c2-8fe3-956808caf8c5 Tickets resolved this week:
Expand Jira server DuraSpace JIRA columns key,summary,type,created,updated,due,assignee,reporter,priority,status,resolution maximumIssues 20 jqlQuery filter=13111 serverId c815ca92-fd23-34c2-8fe3-956808caf8c5 Tickets created this week:
Expand Jira server DuraSpace JIRA columns key,summary,type,created,updated,due,assignee,reporter,priority,status,resolution maximumIssues 20 jqlQuery filter=13029 serverId c815ca92-fd23-34c2-8fe3-956808caf8c5
Minutes
Next sprint starts next week!
- Lots of work happened during the sprint - many CTS tests filled in. Nice job!
- Sprint 2 Strategy and Goals
- Goal: get to the Release Candidate
- There are a number of tickets there that we know we want to address. Priority on those first.
- Setup Release Testing work - pages, testing that the process still works and address any issues seen.
- Documentation
- Jared suggests focusing on the maybe 5 tickets that are bugs, leaving new features for later.
- Suggestion of looking at all tickets to prioritize them.
- Someone can look at fcrepo-camel-toolbox and java client to get an idea of what needs to be done there.
- Secondary Goal: tool set. Priority would be to update camel-toolbox and java client first, vagrant last (as it depends on the other things and may not be much more work to update).
- Ben P. suggests documenting the changes that are needed to the fcrepo tool set: fcrepo-camel-tool box, java client.
- Goal: get to the Release Candidate
Open questions:
Jira server DuraSpace JIRA serverId c815ca92-fd23-34c2-8fe3-956808caf8c5 key FCREPO-2730 - Tests are old tests, but they only break on this branch based on new stuff Jared is doing in his PR.
- Mac 10.10.5 doesn't show this error. (10.10.3 = Yosemite)
- 4 tests failing in FedoraLDPIT tests. Same 4 tests failing. Something to do with setting text HTML in header - to return the web page. Maybe something to do with how Grizzy is working; may be a timing issue.
- Peter E. Do we think this is a network/stack/socket communication problem? Any leads on what's causing it? He's seen some weirdness in their batch loading clients in the network HTTP/TCP stack that weren't working in Mac OS High Sierra, but worked on Sierra. High Sierra may have broken some networking issues. Danny B. suggests leaving it since it may be a Mac issue - but many of us use Mac OS's to build; we'd have to ignore those tests. Can we do a conditional ignore on Mac OSX's?
- Jared suggests we try to look at this more. In the test, in Velocity the SessionFactory and http servlet request is injected, using context...?. Maybe something he's written there is not the best way to do this. Info he's trying to get is that it needs to know if it is a memento and if it's versionable. Maybe there's an easier/better way to get that data?
- One proposal – have someone look at it now
- Or make a ticket, put a conditional ignore on the tests, put some manual tests for this in the release plan, and keep moving forward, addressing this later.
- Ben Pennell may take a short look at it. (He has a High Sierra mac)
- Data URIs in the constrainedBy link header
- Default response on malformed RDF is a Data URI in the constrained By link. We are not using data uris anywhere else. You can't just easily read the response and see what's happening there.
- No objection to changing that. Danny B. will create a PR.
- Prefer headers on Mementos: https://github.com/fcrepo4/fcrepo4/pull/1420
- Question1: Should the original resource return <> a ldp:Container and <> a ldp:RDFSource when omitting server managed triples (currently these are being omitted in OriginalResource but not the Memento)
- The thought is that this is a new bug - that the original resource should return those two triples. Danny B will create this ticket.
- Danny B will create a documentation ticket for what the SMT's actually are.
- Question2: How should fedora respond to requests to Prefer omit
- In theory they should be the same - that what you see with the original based on the representation request, should look the same in the memento.
- Proposal 1: Mementos should behave like the original resource
- We'd like to go with this.
- Question1: Should the original resource return <> a ldp:Container and <> a ldp:RDFSource when omitting server managed triples (currently these are being omitted in OriginalResource but not the Memento)
- All AuthZ tests assume literal agent values
- Danny believes we have some way to handle this. You can specify the baseURI for agents? The actual logic is backwards from expected. It retains the comparison between the username from current user and the agent value - is still a string comparison of just the user name. The BaseURI user webac uri prefix, its not being added to the principal from the container, but it is being stripped coming from the WebAC. Logically you end up comparing things in the correct sort of way.
- Maybe the fix is to make sure that the values going into the ACL's are URIs. Any of the agents that are being tested by the CTS should probably be URI's. Then when running against fedora, we'd have to specify the agent base URI to start up the server with.
- Need to start collecting a recipe of how to configure your fedora to run the CTS on it. (external content setup, webac agent setup, etc)
- CTS is assuming HTTP basic auth; leaving out server certs, OAuth, etc.. What should we support? What does the Fedora API have to say about how it get a user name from the request? Is anything specified for that?
- WebID passed in the header? WebID TLS - auth using WebID – Solid spec mentions this by name. https://github.com/solid/solid-spec#webid-tls
- Maybe create an issue for this and address it during the upcoming sprint.
- Solid spec mention WebID and WebID TLS, but don't seem to be musts.
- Question of what are we assuming about WebID based on what Solid requires?
- Zimeon raised a point about users and names and we should check in with him
- All of CTS assumes basic auth but some systems may not be using basic auth. Would be hard to cover testing all auth systems. We could work with folks implementing the spec and see what they are using.
- Aaron Birkland mentioned CLAW and JWT's - solution was to have the system hand off a http client off to APIX, which does all the JWT stuff. We could add an authentication interface for the CTS in order to delegate authentication to the implementation. The tradeoff – Fedora implementors will have to implement the interface. However, this approach might be more practical than trying to support specific systems folks are using.
Announcements
- Danny sang a song about announcements
- Sprint progress/checkin
- CTS has a few small bugs and feature requests remaining, almost all the tests complete
Jared is going to try 6.1 notification events.
Still need the machinary to listen to the notifications.
Modeshape sends out a lot of notifications that are "not exactly modifications"
Is there an example of what is strictly expected in terms of format? It may be difficult to test
There are a few MUSTs which are testable, such as identifier and activity stream namespace
awoods: There are about 17 issues, do we want to defer them or do they need to be addressed now or can some be closed?
- danny will go through the tickets to try to make this determination, awoods will double check
- CTS has a few small bugs and feature requests remaining, almost all the tests complete
- Issues to discuss
- Reviewing tickets in the sprint board https://jira.duraspace.org/secure/RapidBoard.jspa?rapidView=40
2730 - It may be operating system related
2778 - mostly done, tests mostly passing, but there is one that may or may not be related that is failing
2848 - the actual ticket is done. But there is an issue with date formatting, something that is formatting the dates is changing the significant digits which is actually changing the timestamp if a timestamp ends with a 0. So 140 milliseconds becomes 14 milliseconds in the memento.
Danny - create another ticket for this second issue
Bethany - sure, but we wouldn't want to merge this issue until the second ticket is addressed. Bethany still interested in keeping her name on the ticket
Danny - maybe a second ticket isn't necessary since the issue is documented in the original ticket
2854 "Defining acl:accessToClass without an acl:default predicate has no benefit" - has been converted to a documentation ticket. Basically warn people that if they are doing something, it probably doesn't do what they think it does.
cts208 - was merged yesterday
- cts206 (Inheritance and Default ACLs)
- The issue was that there is no definition for what the backstop ACL should be, and that there is no requirement that the default acl be exposed.
- peter: two suggestions:
- have a way to retrieve the effective authorization per node regardless of whether something is directly assigned,
- or just expose the backstop ACL explicitly off of the root node (this would just solve the initial testability issue)
- Peter will begin creating a sidecar modification for spec related to this.
- Do a 404 check for the time being.
- 2092
has existed for a year, may not be essential.Jira server DuraSpace JIRA serverId c815ca92-fd23-34c2-8fe3-956808caf8c5 key FCREPO-2092 - IndirectContainer related. There were triples not being persisted.
- Medium gnarl, luke-warm interest, so may not be essential for version 5.0
- Reviewing tickets in the sprint board https://jira.duraspace.org/secure/RapidBoard.jspa?rapidView=40
- Newsletter
- Should we co-opt the existing newsletter, or send a separate tech update message?
- Updates on sprint progress, effort to remove modeshape dependencies, state of the 5.0 effort.
- Have a link from the newsletter to the tech update
- Danny will compile first edition of the tech update letter. "The road to no Modeshape"
Future Agenda Topics:
- Amherst College's acrepo apache camel services: https://gitlab.amherst.edu/acdc/repository-extension-services
- Reviving OAI