Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

https://github.com/DSpace-Labs/DSpace-Docker-Images/issues/57

branchJDKtag (proposal 1)tag (proposal 2)DockerfileMavenANTTomcat
master8master-jdk8master/Dockerfile.dspace/src/main/docker/jdk8maven:latest1.10.5tomcat:8
dspace-6_x8dspace-6_x-jdk8dspace-6_x/Dockerfile./src/main/docker/jdk8
maven:latest1.10.5tomcat:8
dspace-5_x8dspace-5_x-jdk8dspace-5_x-jdk8/Dockerfile./src/main/docker/jdk8maven:latest1.10.5tomcat:8
dspace-5_x7dspace-5_x-jdk7dspace-5_x/Dockerfile./src/main/docker/jdk7maven:3.5.4-jdk-7
or maven:latest
1.9.13tomcat:7.0.90-jre7
dspace-4_x8dspace-4_x-jdk8dspace-4_x-jdk8/Dockerfile./src/main/docker/jdk8maven:latest1.10.5tomcat:8
dspace-4_x7dspace-4_x-jdk7dspace-4_x/Dockerfile./src/main/docker/jdk7maven:3.5.4-jdk-7
or maven:latest
1.9.13tomcat:7.0.90-jre7

...

branchJDKtagDockerfileNote
master8master-jdk8-testdspace/src/main/docker/jdk8/Dockerfile.jdk8-testNo localhost restriction for solr, no ssl required for rest
dspace-6_x8dspace-6_x-jdk8-testdspace/src/main/docker/jdk8/Dockerfile.jdk8-testNo localhost restriction for solr, no ssl required for rest
dspace-5_x8dspace-5_x-jdk8-testdspace/src/main/docker/jdk8/Dockerfile.jdk8-testNo localhost restriction for solr, no ssl required for rest
dspace-5_x7dspace-5_x-jdk7-testdspace/src/main/docker/jdk7/Dockerfile.jdk7-testNo localhost restriction for solr, no ssl required for rest
dspace-4_x8dspace-4_x-jdk8-testdspace/src/main/docker/jdk8/Dockerfile.jdk8-testNo localhost restriction for solr, no ssl required for rest
dspace-4_x7dspace-4_x-jdk7-testdspace/src/main/docker/jdk7/Dockerfile.jdk7-testNo localhost restriction for solr, no ssl required for rest

...

  • Question: are there any other resources we should add to .dockerignore?
  • Can we place multiple Dockerfiles into separate directories?
    • When building from the command line, it is possible to build with a Dockerfile in a subdirectory.
    • Unfortunately, the automated build process on Docker Hub changes the context directory for the build and cannot find necessary resources if the Dockerfile does not live in the root directory.
    • Solution: create multiple Dockerfiles in the root directory with meaningful names.
  • We can create contextual README files for each release.  
    • Unless we move the Dockerfiles to a subdirectory, we cannot change the README that displays in Docker Hub.
    • Solution: I have added a note to the main DSpace README file (see the PR above)

Additional Resources