Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

https://github.com/DSpace-Labs/DSpace-Docker-Images/issues/57

Per the DevMtg 2018-09-26, we will override/optimize the Docker images for development purposes.

  • Localhost restriction for SOLR will be removed
  • SSL requirement for the rest service will be removed
tag (proposal 2masterdspace-5_x
branchJDKtag (proposal 1))DockerfileMavenANTTomcat
master8master-jdk8/Dockerfile.jdk8maven:latest1.10.5tomcat:8
dspace-6_x8dspace-6_x-jdk8dspace-6_x/Dockerfile.jdk8
maven:latest1.10.5tomcat:8
dspace-5_x8dspace-5_x-jdk8dspace-5_x-jdk8/Dockerfile.jdk8maven:latest1.10.5tomcat:8
dspace-5_x7dspace-5_x-jdk7/Dockerfile.jdk7maven:3.5.4-jdk-7
or maven:latest
1.9.13tomcat:7.0.90-jre7
dspace-4_x7dspace-4_x-jdk7dspace-4_x/Dockerfile.jdk7maven:3.5.4-jdk-7
or maven:latest
1.9.13tomcat:7.0.90-jre7

If we support multiple Dockerfiles, what other variants would be useful to build?

...

branchJDKtagDockerfileNote
master8master-jdk8-test/Dockerfile.jdk8-testNo localhost restriction for solr, no ssl required for rest
dspace-6_x8dspace-6_x-jdk8-test/Dockerfile.jdk8-testNo localhost restriction for solr, no ssl required for rest
dspace-5_x8dspace-5_x-jdk8-test/Dockerfile.jdk8-testNo localhost restriction for solr, no ssl required for rest
dspace-5_x7dspace-5_x-jdk7-test/Dockerfile.jdk7-testNo localhost restriction for solr, no ssl required for rest
dspace-4_x8dspace-4_x-jdk8-test/Dockerfile.jdk8-testNo localhost restriction for solr, no ssl required for rest
dspace-4_x7dspace-4_x-jdk7-test/Dockerfile.jdk7-testNo localhost restriction for solr, no ssl required for rest

Implementation Notes

...

  • Can we place multiple Dockerfiles into separate directories?
    • When building from the command line, it is possible to build with a Dockerfile in a subdirectory.
    • Unfortunately, the automated build process on Docker Hub changes the context directory for the build and cannot find necessary resources if the Dockerfile does not live in the root directory.
    • Solution: create multiple Dockerfiles in the root directory with meaningful names.
  • We can create contextual README files for each release.  
    • Unless we move the Dockerfiles to a subdirectory, we cannot change the README that displays in Docker Hub.
    • Solution: I have added a note to the main DSpace README file (see the PR above)

...