Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

  • (Providing the background for the issue)
  • Current implementation of Fedora Commons (fcrepo) extensively uses Guava iterators
  • Allows one to do lazy processing...functional idioms for writing codes
  • Java 8 allows one to use core streams library, deprecating the need for Guava
  • Best to use core packages rather than rely upon Guava

...

  • Is there time to find a more ideal solution to enum now?
  • Or, is it viable to avoid merging now (merging the PR without an alternative to the enum solution requires that work be thrown away later)

...

  • The PR is quite large
  • 1/10th of the entire code base; Rebasing it is complete hell
  • To keep iterating on this in order to add additional functionality while merging other PR's into the code base presents other problems
  • Specifically, the task of managing the PR becomes increasingly difficult
  • Definitely should remove enum, but advocates merging the PR as it is
  • Then, replace enum immediately after
Soroka:
  • Why would this approach prevent us from not using the enum at all and taking the time now to refactor the PR?

...

...

Atomic Batch Operations

Whiklo

...