...
Meeting 02 - September 2, 2016
- Nick Ruest
- Justin Simpson
- David Wilcox
- Esmé Cowles
- Youn Noh
- Andrew Woods
- Michael Durbin
- Bethany Seeger
- Joshua Westgard (2nd half)
Agenda
- Open issues
- Review ticket process
- Squashing commits
- Review use of IRC
- Helping everyone use jar and load data
- We need data with cross-references and external references
- We need data with cross-references and external references
- Consider refactoring export to have 'ldp:contains' passed in?
- IMPORT!
- Review tickets
- AuthZ
Minutes
Ticket review
- 2127 justin will add step by step instructions with output to this ticket, to provide more info.
- 2130 Esmé will take over ticket, and start on import utility, get done what he can for others to review on Monday. this will be a basic, skeletal version, working with a small repo, containing a couple of small handbuilt resources.
- 2132 we reviewed Youn's test plan doc and resolved comments https://docs.google.com/document/d/1WW0dU9LDWvnRPGbzKpIE-ODkGq39md17sKkWVXC0P8U/edit
Nick and Youn will work on adding this to the wiki - 2133 Josh has sample data in sample data repo, almost ready to close ticket.
Youn has sample data, and is working on a script to put that data into a fedora repo, currently living in a google drive folder.
Esmé provided feedback on how to modify the existing sample owl file, Justin will help next week with scripting the loading of owl data, if needed. - 2134 will leave open for extra comment/input untill next week
- 2135 leaving open and unassigned until next week
- 2139 low priority
- 2143 and 2144 leaving open til next week
- 2146 discussed, needs to be revisited, once basic import tool exists - some discussion about how to pass in and save config (command line and
- 2155 Andrew is working on integration tests - run export and import from command line, to test roundtripping.
Esmé suggested writing the test in the other order - import a fixture, then export it. Andrew will commit initial driver level tests first, then create a follow on ticket for sub-module level tests
Some take aways from the ticket review discussion:
General process for making sample datasets:
write up a document that provides links to raw data
write a script to import that into a fedora repo
do an fcr:backup on that repo
tar up the output of fcr:backup
add all the outputs from above steps to fcrepo sampledata github repo
small test fixtures will be tested from integration tests
larger sample datasets (like in fcrepo sampledata) will be tested that work with the fcrepo-vagrant as the test environment, and documented in the test plan, which will be added to the wiki.
we reviewed process for how to use jira:
-make sure to take ownership of tickets you are working on
-mark them as in progress, or ready for review, etc as you go
we reviewed the Pull Request process:
-put in a pull request
-others comments
-based on comments, you make subsequent commits (don't squash)
-once the pull request is complete, then squash down to one commit before merging to master
This is not a hard and fast rule, there can be exceptions,
-sometimes it is better to not squash, or squash to a set of commits, if there is logical separation between commits
-sometimes the branch has to be rebased, due to other work going into master, and in that case it can make sense to squash when rebasing.
Esmé provided a link to a good blog post on squashing commits by Jeremy Friesen: http://ndlib.github.io/practices/one-commit-per-pull-request/
discussed communication
-using irc, make sure irc client can notify you when your name is used, try to keep irc on so you can participate during the sprint
discussed how to actually get the code, making sure all of us can build and/or acquire the jar file and run it. Ask in irc if there are questions.
talked about process of dependency management and use of ldp:contains, Esmé and Andrew will do some refactoring.