Page History

...

•  Backchannel on #angular-ui in Slack. Join us at https://goo.gl/forms/s70dh26zY2cSqn2K3Art gives his updates on latest code changes in https://github.com/DSpace/dspace-angular (ART: Please add or link in your notes)
• Testing works and has been merged
  • Tests have been added for the reducers in the code
• The way actions work has changed to make better use of typescript
  • They're now classes, with a type property for their key and the constructor to create them. (example)
  • That way we can use type checking to ensure the reducer only works with the correct actions. (example)
• npm-shrinkwrap was added
  • adds npm-shrinkwrap.json to the project: a file that tracks all dependency versions
  • every new install will use those exact versions
  • From now on, if you install a new package
    • using "npm install some-package --save", you don't have to do anything, shrinkwrap will run automatically
    • by modifying package.json manually, you'll have to run npm run rewrap to update npm-shrinkwrap.json
  • All updates / new commands are also in the README
• Configuration. What do we want to use: https://github.com/DSpace/dspace-angular/pull/42/
  • Typescript or Javascript
  • JSON (no comments allowed)
  • YAML (but not frequently used with JS projects?)
  • Maybe we go with Javascript for now (as widely understood & simple). We could always translate something else to JS later
• PR for a PageNotFound component: https://github.com/DSpace/dspace-angular/pull/44
• PR for a Spinner (loading) component: https://github.com/DSpace/dspace-angular/pull/43
  • adds SpinnerService with an activate and deactivate method
  • If you create a spinner that has to wait on an async call (a response from REST), call activate() before the call, and deactivate() when the call completes
• PR for a Serializer (translate from REST to models & back): https://github.com/DSpace/dspace-angular/pull/45
  • There's an interface, and an implementation for JSON API
  • If the rest team doesn't go with JSON API, the changes should be limited to that class
• Style guide now has guidelines for separate modules (LINK?)modules https://angular.io/styleguide#!#04-09
  • create a separate module for each feature
  • use a SharedModule for pipes and directives that are shared across the app
  • use a CoreModule for singletons that are needed across the app
    • Note that not every service needs to be in this module, if it's only need across a subset of the app, move it up to the first module that encompasses them all, not further
  • Art will create an issue to refactor our code to match this structure
• Need more help reviewing code
  • Tim can create a small Review team in GitHub so we can @ mention them in tickets
• Slack #angular-ui channel now gets GitHub ticket / PR updates
• Question on Debugging code? What do we use?
  • Chrome browser Dev tools
  • https://chrome.google.com/webstore/detail/redux-devtools/lmhkpmbekcpmknklioeibfkpmmfibljd?hl=en
  • npm run watch dev (Will show errors in console)
  • Hot Module Replacement (HMR) module: https://github.com/AngularClass/angular2-hmr
    • Throws syntax error into browser window (via an overlay)
    • Can be helpful in debugging issues.
    • Art said he looked at it in Dec, but wasn't sure if it worked with Universal, etc.

...