Page tree

Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

Developers Meeting on Weds, Aug 16, 2017

 

Info
titleToday's Meeting Times

...

  • NEXT DSpace 7 UI MEETING: TOMORROW, Aug 17 at 15:00 UTC (11:00am EDT) in Google Hangouts

Discussion Topics

  1. Tim will be out next Tues / Weds, attending the DSpace User Group meeting at Georgetown. (Terry Brady & Mark Wood will also be at this meeting)
    • Do we want to cancel next week's DevMtg (Aug 23 at 15UTC)? Or does someone else want to organize/run the meeting?
  2. DSpace 6.2 Immediate Release to fix Hibernate issues:

    1. Jira
      serverDuraSpace JIRA
      serverIdc815ca92-fd23-34c2-8fe3-956808caf8c5
      keyDS-3659

    2. Jira
      serverDuraSpace JIRA
      serverIdc815ca92-fd23-34c2-8fe3-956808caf8c5
      keyDS-3648
    3. Jira
      serverDuraSpace JIRA
      serverIdc815ca92-fd23-34c2-8fe3-956808caf8c5
      keyDS-3656
    4. Jira
      serverDuraSpace JIRA
      serverIdc815ca92-fd23-34c2-8fe3-956808caf8c5
      keyDS-3660
       
    5. Any other very obvious wins to "dspace-6_x" branch? https://github.com/DSpace/DSpace/pulls?utf8=%E2%9C%93&q=is%3Apr%20is%3Aopen%20base%3Adspace-6_x%20
  3. Discussion of DB Connections in DSpace 6 (Hibernate) vs DSpace 5. (More notes at DSpace Database Access)
    1. In DSpace 5, each "Context" established a new DB connection. Context then committed or aborted the connection after it was done (based on results of that request).  Context could also be shared between methods if a single transaction needed to perform actions across multiple methods.
    2. In DSpace 6, Hibernate manages the DB connection pool.  Each thread grabs a Connection from the pool. This means two Context objects could use the same Connection (if they are in the same thread). In other words, code can no longer assume each new Context() is treated as a new database transaction.
      1. This is what we saw in DS-3659, two separate Context objects used the same connection, and one accidentally rolled back the changes of a previous Context (because they were in the same thread).
      2. Should we be making use of SessionFactory.openSession() for READ-ONLY Contexts (or any change of Context state) to ensure we are creating a new Connection (and not simply modifying the state of an existing one)?  Currently we always use SessionFactory.getCurrentSession() in HibernateDBConnection, which doesn't guarantee a new connection: https://github.com/DSpace/DSpace/blob/dspace-6_x/dspace-api/src/main/java/org/dspace/core/HibernateDBConnection.java
  4. DSpace High Priority Tickets

    1. High Priority (Blocker, Critical or Major) and flagged for release

      Expand

      Jira
      serverDuraSpace JIRA
      columnskey,summary,type,created,updated,assignee,reporter,priority,status,fixversions
      maximumIssues20
      jqlQueryfilter = 13904 ORDER BY fixVersion DESC, priority DESC
      serverIdc815ca92-fd23-34c2-8fe3-956808caf8c5


    2. Need Code Review, Flagged for Release

      Expand

      Jira
      serverDuraSpace JIRA
      columnskey,summary,type,created,updated,assignee,reporter,priority,status,fixversions
      maximumIssues20
      jqlQueryfilter=13905 ORDER BY fixVersion DESC, priority DESC
      serverIdc815ca92-fd23-34c2-8fe3-956808caf8c5


  5. DSpace + Spring: Slack Discussion on whether DSpace codebase should move more towards the Spring way of doing things (e.g. Dependency Injection via beans) or the traditional DSpace patterns (e.g. classloaders with little DI).
    1. This was asked on dspace-devel: https://groups.google.com/d/msg/dspace-devel/oBWibfQUXzI/y05K-wpLAgAJ
  6. DS-3372 and DS-3587: discussion required, should we add more SQL dialect support? MySQL, MS SQL? Are we ready to support, test and maintain these dialects in the future?
    1. Also asked on dspace-devel: https://groups.google.com/d/msg/dspace-devel/UfTU7AFZjs0/UOgiSnJKAgAJ
  7. Other Tickets needing discussion (Please feel free to add any you wish to discuss under this topic)
  8. Reviewing JIRA Tickets or PRs
    1. Please feel free to bring any that need eyes / immediate discussion
    2. JIRA Backlog of "Received" tickets
    3. All open PRs

...