2019-02-07 DSpace 7 Working Group Meeting

Date

07 Feb 2019 from 15:00-16:00 UTC

Location: https://duraspace.zoom.us/my/dspace (Meeting ID: 502 527 3040).

• More connection options available at DSpace Meeting Room

Agenda

• (15 mins) Developer Stand Up - Developers give brief updates on their effort (or their team's effort).

  • Update/see "Current Work" section below based on your status. Please feel free to update prior to meeting.
  • Please highlight any new work (needing reviews/testing), any blockers (for you), and any discussion topics you may have.
• (30 mins) General Discussion Topics
  1. Final Approval DSpace 7 Working Group Processes. PLEASE REVIEW PRIOR TO MEETING.
     1. https://docs.google.com/document/d/12BZVIGU9FhaL6Dkotsc603Fh1611mITfARFRWrwTXpo/edit
  2. Upcoming DSpace Entities PR (to master) from DSpace 7 Entities Working Group
  3. Next deadline for DSpace 7 Preview Release (Early March)
• (15 mins) Planning for next week
  
  • Assigning PRs for Review
  • Next tasks from Development Planning Spreadsheet

Attendees

• Art Lowel (Atmire)

• Andrea Bollini (4Science)

• Tim Donohue

• Lieven Droogmans

• Mark H. Wood
• Giuseppe Digilio (4Science)
• Ben Bosman
• Pascal-Nicolas Becker
• Chris Wilper
• Terrence W Brady
• Pablo Prieto
• Paulo Graça

Current Work

Tickets / PRs In Progress

1. (Angular) Submission implementation: https://github.com/DSpace/dspace-angular/pull/279 (Giuseppe Digilio (4Science)) (Updates requested)
2. (Angular) Administrative Item Edit (Art Lowel (Atmire) ) (work in progress)
3. (Angular) Browse page links in the menu and on community and collection homepages (Art Lowel (Atmire) ) (work in progress)
4. (Angular) Adding Accessibility via Travis CI  https://github.com/DSpace/dspace-angular/pull/356 (work in progress) (Lower priority)
5. (REST) Workflow Endpoint: https://github.com/DSpace/DSpace/pull/2312 (Andrea Bollini (4Science) ) (Updates requested. Hibernate issues with integration tests.)
6. (REST) MyDSpace Endpoint (Andrea Bollini (4Science)  (work in progress)
7.  (REST Contract) Endpoint for EPerson profile PATCH requests: https://github.com/DSpace/Rest7Contract/pull/49 (Michael Spalti) (Changes requested)
8. (Backend) One Webapp Backend - Initial PR: https://github.com/DSpace/DSpace/pull/2265 (Tim Donohue ) (work in progress)
9. (Backend) Upgrading Solr Server for DSpace - Initial PR: https://github.com/DSpace/DSpace/pull/2058 (Terrence W Brady and Mark H. Wood) (work in progress)

PRs Needing Review

1. (REST Contract) Enhance description of search endpoints https://github.com/DSpace/Rest7Contract/pull/50 (Ben Bosman, Paulo Graça )
2.  (REST Contract) Mapping Collection (UPDATED) https://github.com/DSpace/Rest7Contract/pull/52 (Andrea Bollini (4Science) Ben Bosman )
3. (REST Contract) Edit Homepage news: https://github.com/DSpace/Rest7Contract/pull/45 (Tim Donohue, Paulo Graça) (Lower priority)
4. (REST Contract) Group and eperson management: https://github.com/DSpace/Rest7Contract/pull/41 (Andrea Bollini (4Science) - quick review, Tim Donohue)
5. (REST) Item CRUD: https://github.com/DSpace/DSpace/pull/2290 (Terrence W Brady)
6. (REST) Bug in Error Handling (caused by OpenSearchController): https://github.com/DSpace/DSpace/pull/2343 (Approved)
7. (REST) Updating Owning Collections: https://github.com/DSpace/DSpace/pull/2283 (UNASSIGNED, Tim Donohue )
8. (REST) Manage Metadata Registry: https://github.com/DSpace/DSpace/pull/2291 (re-review Paulo Graça , Tim Donohue )
9.  (REST) Metadata as a Map: https://github.com/DSpace/DSpace/pull/2287 (Approved, but related to next PR #347)
10. (Angular) Metadata as a Map: https://github.com/DSpace/dspace-angular/pull/347 (Giuseppe Digilio (4Science))
11.  (Angular) Delete Communities & Collections: https://github.com/DSpace/dspace-angular/pull/350
12.  (Angular) Modifying Metadata Registries: https://github.com/DSpace/dspace-angular/pull/355 (Paulo Graça, still in review. Had questions as testing resulted in error)
13. (Angular) Create/Edit for Communities & Collections: https://github.com/DSpace/dspace-angular/pull/349 (Tim Donohue)

PRs Merged this week!

1.  (REST Contract) Metadata as a Map: https://github.com/DSpace/Rest7Contract/pull/39
2.  (REST Contract) Documenting our Design Principles: https://github.com/DSpace/Rest7Contract/pull/48
3.  (REST) Default URL for Rest Service https://github.com/DSpace/DSpace/pull/2337
4.  (REST Contract) Move Item: https://github.com/DSpace/Rest7Contract/pull/34 
5.  (REST) Community & Collection CRUD: https://github.com/DSpace/DSpace/pull/2277

BLOCKED

1. (Angular) Move Item Component: https://github.com/DSpace/dspace-angular/pull/335
   1. Blocked by DSpace PR#2283
2. (Angular) Item-Collection Mapper:  https://github.com/DSpace/dspace-angular/pull/348
   1. Blocked by Contract #52
   2. Blocked by DSpace PR#2282

Delayed / Needs Discussion

1. (REST) Scripts & Processes endpoint: https://github.com/DSpace/Rest7Contract/pull/17
2. Discussion of deletion of EPeople for GDPR compliance (from Pascal)
   1. https://github.com/DSpace/DSpace/pull/2229. NOTE: item.getSubmitter() will return null if EPerson deleted.

Notes

• Updates from developers are noted in the "Current Work" section above
• Discussion
  • Working Group Processes doc: https://docs.google.com/document/d/12BZVIGU9FhaL6Dkotsc603Fh1611mITfARFRWrwTXpo/edit
    • General approval for the new meeting structure & the processes laid forth.
    • Some discussion around how to keep PRs "small".  The "1,000 lines or less" note is a bit arbitrary.
    • Also there's a tension between having a small PR and having a PR that is well documented (via comments) and has thorough integration tests.  So, sometimes, a slightly larger PR is better because it's easier to understand
    • Tim notes the "1,000 lines or less" was very arbitrary. We can change this to be a little more generic & note that ITs and comments should not be considered a part of the line count.
    • Paulo asks about requirements for a meeting proxy.  If you don't have a proxy, what do you do?
      • Tim is available to be everyone's proxy.  If you have an update to share at a meeting & are unable to attend, send that update to Tim & he will report it to the team (and act as your proxy)
  • Upcoming PR from Entities Working Group
    • Three PRs: one for contract, one for REST impl, one for Angular UI
    • Initial PR will only be the backend changes (database structure) and UI  views (e.g. Item homepage updates, browse updates, etc).  Test data will be provided that can be used to test the PR
      • Creation of new Entities is specifically not included, as it is dependent on the Submission UI work from the DSpace 7 team.
    • All the Entities work was developed by Atmire, but has been reviewed & tested by non-Atmire developers (Tim, Paulo, Alexander, and others).  So, this will not be the first review for this code.  The team & the reviewers have tried to align all this work with the existing best practices of DSpace 7 team.
    • Tim will create the PRs in the next week (or so)
  • Deadline for Preview Release
    • Major outstanding features are the Entity work and Submission/Workflow UI. 
    • Atmire's remaining development work looks to only be 2 weeks of effort.  However, review process is unknown (most of the Preview features are already under review, with exception of Entity work and the new Admin side menu)
    • 4Science effort is likely 2-3 weeks, however it's dependent on Andrea's schedule.  He's wanting to ensure all REST contract/implementation features get a thorough review, and that takes away from his time to complete the Workflow PR, etc.
      • No other developers currently available to help at 4Science
      • We (DSpace 7 team) will try and ensure Andrea's time is minimized on minor reviews, so that he can concentrate more on the Workflow PR & major reviews.
    • Best "guess" date right now is early March for Preview
      • Much later than that, and it will be difficult to make the April Beta release.
  • Admin Menu Mockups
    • Art Lowel (Atmire) demoed them for everyone
    • Some possible usability concerns (but all seem minor), need to test a few screens with real users to get feedback.
      • Do we need a "Go" or "Confirm" button in the pop-ups to select Collection/Community to create within?
      • Should we be displaying UUIDs? Are those too confusing?
    • Should the "Create Item" use features of new Submission UI / My DSpace
      • Specifically, MyDSpace will have a "drop area" where you can drop a file to create one or more Items at once. For example, drop a BibTex and create multiple Items at once
      • May want to have a drop area in the Create Item popup too.
    • Questions about MyDSpace page. Should it appear in this side menu?
      • Side menu is currently for Admin actions only.  Will only appear for Full Admins, Community Admins & Collection Admins.
      • MyDSpace page might be linked from either the user account (upper right) or a new icon in upper right (that appears once logged in). Need to decide.
    • Overall, all agree that the approach looks good for now.  We'll want to do some usability testing with real users in the future (for the whole UI) and may want to tweak some of the screens later based on any feedback they provide.
  • Meeting wrap-up. Next meeting on Feb 14.