Page tree
Skip to end of metadata
Go to start of metadata

Developers Meeting on Weds, Aug 2, 2017

 

Today's Meeting Times

Agenda

Quick Notes / Reminders

  • NEXT DSpace 7 UI MEETING: TOMORROW, Aug 3 at 15:00 UTC (11:00am EDT) in Google Hangouts

Discussion Topics

  1. DSpace 6.2 Immediate Release to fix Hibernate issues:

    1. DS-3659 - Getting issue details... STATUS

    2. DS-3648 - Getting issue details... STATUS
    3. DS-3656 - Getting issue details... STATUS
    4. DS-3660 - Getting issue details... STATUS  (Not a hibernate specific issue, but an important bug that seems to have been surfaced in 6.1)
    5. Any other very obvious wins to "dspace-6_x" branch? https://github.com/DSpace/DSpace/pulls?utf8=%E2%9C%93&q=is%3Apr%20is%3Aopen%20base%3Adspace-6_x%20
  2. Discussion of DB Connections in DSpace 6 (Hibernate) vs DSpace 5.
    1. In DSpace 5, each "Context" established a new DB connection. Context then committed or aborted the connection after it was done (based on results of that request).  Context could also be shared between methods if a single transaction needed to perform actions across multiple methods.
    2. In DSpace 6, Hibernate manages the DB connection pool.  Each thread grabs a Connection from the pool. This means two Context objects could use the same Connection (if they are in the same thread). In other words, code can no longer assume each new Context() is treated as a new database transaction.
      1. This is what we saw in DS-3659, two separate Context objects used the same connection, and one accidentally rolled back the changes of a previous Context (because they were in the same thread).
      2. Should we be making use of SessionFactory.openSession() for READ-ONLY Contexts (or any change of Context state) to ensure we are creating a new Connection (and not simply modifying the state of an existing one)?  Currently we always use SessionFactory.getCurrentSession() in HibernateDBConnection, which doesn't guarantee a new connection: https://github.com/DSpace/DSpace/blob/dspace-6_x/dspace-api/src/main/java/org/dspace/core/HibernateDBConnection.java
  3. DSpace 6.3? Release Planning: A few main options for the 6.2 were discussed last week (http://irclogs.duraspace.org/index.php?date=2017-07-26)

    1. A formally planned 6.3 release. This would necessitate a 6.2 Release Team (ideally of 2 or more volunteers), one or more Release Candidate(s), possibly a mini-Testathon. It'd have the advantage of providing a more thorough bug-fix release, but would require more effort to achieve this.
    2. An ad-hoc, quick 6.3 release.  This would essentially be more like 6.1 (but less large in size). We'd scope 6.2 to a "major bug fix" release, and just fix the major bugs discovered in 6.1 (ideally after further testing by DCAT or similar).  It'd have the advantage of being (likely) more rapid release (hopefully allowing developers to work in parallel on 7.0), but it may not be as thorough.
    3. A quick 6.3 with a formally planned 6.4: This is a combo of the above approaches.  It'd provide the benefits of a quick 6.2 release, but it'd necessitate finding volunteers to manage a 6.3 (perhaps later in the year, timeline TBD).
  4. DSpace High Priority Tickets

    1. High Priority (Blocker, Critical or Major) and flagged for release

       Click here to expand...

      Key Summary T Created Updated Assignee Reporter P Status Fix Version/s
      Loading...
      Refresh

    2. Need Code Review, Flagged for Release

       Click here to expand...

      Key Summary T Created Updated Assignee Reporter P Status Fix Version/s
      Loading...
      Refresh

  5. DSpace + Spring: Slack Discussion on whether DSpace codebase should move more towards the Spring way of doing things (e.g. Dependency Injection via beans) or the traditional DSpace patterns (e.g. classloaders with little DI).
    1. This was asked on dspace-devel: https://groups.google.com/d/msg/dspace-devel/oBWibfQUXzI/y05K-wpLAgAJ
  6. DS-3372 and DS-3587: discussion required, should we add more SQL dialect support? MySQL, MS SQL? Are we ready to support, test and maintain these dialects in the future?
    1. Also asked on dspace-devel: https://groups.google.com/d/msg/dspace-devel/UfTU7AFZjs0/UOgiSnJKAgAJ
  7. Other Tickets needing discussion (Please feel free to add any you wish to discuss under this topic)
  8. Reviewing JIRA Tickets or PRs
    1. Please feel free to bring any that need eyes / immediate discussion
    2. JIRA Backlog of "Received" tickets
    3. All open PRs

Ticket Summaries

  1. Help us test / code review! These are tickets needing code review/testing and flagged for a future release:

     Click here to expand...

    Key Summary T Created Updated Assignee Reporter P Status Fix Version/s
    Loading...
    Refresh

  2. Newly created tickets this week:

     Click here to expand...

    Key Summary T Created Assignee Reporter P Status
    Loading...
    Refresh

  3. Old, unresolved tickets with activity this week:

     Click here to expand...

    Key Summary T Created Updated Assignee Reporter P Status
    Loading...
    Refresh

  4. Tickets resolved this week:

     Click here to expand...

    Key Summary T Created Assignee Reporter P Status Resolution
    Loading...
    Refresh

  5. Tickets requiring review. This is the JIRA Backlog of "Received" tickets: 

     Click here to expand...

    Key Summary T Created Updated Assignee Reporter P
    Loading...
    Refresh

Meeting Notes

Meeting Transcript