Date

10 Oct 2019 from 14:00-15:00 UTC

Location: https://lyrasis.zoom.us/my/dspace (Meeting ID: 502 527 3040).

• More connection options available at DSpace Meeting Room

Agenda

• (15 mins) Developer Stand Up - Developers give brief updates on their effort (or their team's effort).

  • Update/see "Current Work" section below based on your status. Please feel free to update prior to meeting.
  • Please highlight any new work (needing reviews/testing), any blockers (for you), and any discussion topics you may have.
• (30 mins) General Discussion Topics
  
  1. REST API discussion:  Reminder to all (self included) which endpoints can support which methods
     1. Per our Contract README: https://github.com/DSpace/Rest7Contract/blob/master/README.md#use-of-the-http-verbs-and-http-response-code
     2. Multiple Resource (i.e. Collection) Endpoints (e.g. /items) may support only POST and GET
     3. Single Resource Endpoints (e.g. /items/:uuid:) may support GET, HEAD, PUT, PATCH and DELETE
     4. Sub-paths only act on associations between resources (e.g./items/:uuid:/mappedCollections), and only allow GET, PUT, POST, DELETE of those associations.
        1. We may need to revisit the decisions in these two recent PRs:
           1. https://github.com/DSpace/Rest7Contract/pull/79 (Community & Collection Logo).  Should PUT/DELETE just use /bitstreams/<:logo_uuid>? (as Logos are Bitstreams!)
           2. https://github.com/DSpace/Rest7Contract/pull/80 (Collection Item Templates).  Should PATCH/DELETE just use /items/<:itemtemplate_uuid>? (as Templates are Items!)
  2. Revisiting REST API Projections: https://jira.duraspace.org/browse/DS-3533
  3. (Possible topic for this week or next?) Julius Gruber had questions around multi-language support for Submission forms on Slack
  4. Reviewing & scoping tasks flagged as "NEEDS MORE INFO" in Development Planning Spreadsheet
     1. This is necessary to prepare for the next phase of the DSpace 7 Estimation Process
• (15 mins) Planning for next week
  
  • Assigning PRs for Review
  • Next tasks from Development Planning Spreadsheet

Attendees

• Art Lowel (Atmire) 

• Andrea Bollini (4Science)  

• Tim Donohue

• Lieven Droogmans 

• Mark H. Wood
• Giuseppe Digilio (4Science) 
• Ben Bosman
• Chris Wilper
• Paulo Graça 
• Dimitris Pierrakos 
• Julius Gruber
• Laura Henze

Current Work

Tickets / PRs In Progress

1. (Angular) Adding Accessibility via Travis CI  https://github.com/DSpace/dspace-angular/pull/356 (work in progress) (Lower priority)
2.  (Angular Bug) https://github.com/DSpace/dspace-angular/issues/368 ( Art Lowel (Atmire) )
3. (REST Contract) Edit Homepage news: https://github.com/DSpace/Rest7Contract/pull/45 (Ben Bosman  - has outstanding questions/comments) (Lower priority)
4. (REST) DS-4043: Revisit the security layer of the submission  (work in progress) Andrea Bollini (4Science)
5. (REST) Pagination bug with withdrawn items: https://github.com/DSpace/DSpace/pull/2406 (Dimitris Pierrakos , Ben Bosman - Feedback provided)

PRs Needing Review

1. (REST Contract) Group and eperson management: https://github.com/DSpace/Rest7Contract/pull/41 (Tim Donohue - feedback provided,  Andrea Bollini (4Science) -  feedback provided)
2. (REST) Issue when community has multiple dc.title values https://github.com/DSpace/DSpace/pull/2486 UPDATED ( Tim Donohue - feedback added, Andrea Bollini (4Science))
3. (REST) Oai harvesting setup https://github.com/DSpace/DSpace/pull/2491 (Tim Donohue -  Minor improvements requested,  Andrea Bollini (4Science) - feedback added , Paulo Graça )
4. (REST) Spring security for createAndReturn with parent id https://github.com/DSpace/DSpace/pull/2489 (Tim Donohue -  Minor improvements requested,  Chris Wilper ) 
5. (REST) Authority control bugfixes https://github.com/DSpace/DSpace/pull/2528 (Tim Donohue, Giuseppe Digilio (4Science), Andrea Bollini (4Science))
6. (REST) (Entities) CSV Import fixes, improvements to entity validation: https://github.com/DSpace/DSpace/pull/2522 (Ben Bosman, Paulo Graça - feedback provided) 
7. (NEW) (REST) Scripts and processes endpoint https://github.com/DSpace/DSpace/pull/2529 (Tim Donohue, Dimitris Pierrakos)
8. (NEW) (REST) DS-4337 implement bitstream-bitstreamformat relation endpoints https://github.com/DSpace/DSpace/pull/2503 (Tim Donohue, Ben Bosman)
9. (Angular) Item-Collection Mapper:  https://github.com/DSpace/dspace-angular/pull/348 ( Tim Donohue -  REREVIEW, Art Lowel (Atmire) - provided feedback)
10. (Angular) Shibboleth integration support: https://github.com/DSpace/dspace-angular/pull/429  (Giuseppe Digilio (4Science) reviewed again fixed error with yarn start, Fernando FCT/FCCN, Paulo Graça)
11. (Angular) forceBypassCache should be removed from the RequestService: https://github.com/DSpace/dspace-angular/pull/468 (Art Lowel (Atmire),  Giuseppe Digilio (4Science) issue found)
12. (Angular) Collection pages WIP: https://github.com/DSpace/dspace-angular/pull/472 (Art Lowel (Atmire) - feedback provided, Tim Donohue)
13. (NEW) (Angular) Routing by handle and uuid: https://github.com/DSpace/dspace-angular/pull/490 (Art Lowel (Atmire), Giuseppe Digilio (4Science))

PRs Merged this week!

1.  (REST) Fixing exception error when using UUID on Harvesting process  https://github.com/DSpace/DSpace/pull/2536

Blocked

1. (Blocked PRs go here)

Delayed / Needs Discussion

1. Managing Authorization info in Angular UI: How to pass Authorization rights (i.e. logged in user's access rights) from REST API to Angular?  See for example: https://github.com/DSpace/dspace-angular/issues/393
   1. Can this be achieved via passed HAL "_links" (e.g. the existence of an "edit" link in REST response means you must have Edit rights)?
   2. In July 25 meeting, we noted this probably cannot be resolved with just one simple solution. May need to look at different options for different scenarios
      1. Also likely to need to store/cache a user's Groups in UI layer, as some areas (e.g. Administrative) require knowledge of user group membership
2. REST API Projections: 
   1. Early work begun at https://github.com/DSpace/DSpace/pull/1847.  Discussed in more detail in our Aug 22 meeting.  Overall, this approach seems like a good direction, need volunteers to move it forward.
      1. https://github.com/DSpace/Rest7Contract/issues/2 (discussion resumed by Andrea Bollini (4Science) could be relevant for the projection)
3. Initial Performance Testing from Chris.
   1. https://cwilper.github.io/dspace-perftest/
4. (REST Contract) Edit Homepage News: https://github.com/DSpace/Rest7Contract/pull/45
   
   1. Delayed until after Preview release. General agreement (in meeting on March 21, 2019) that storing HTML in metadata fields is not really ideal behavior.  Metadata (from a librarian standpoint) tends to be free of format-related markup (as that allows for easier sharing, understanding of metadata.  Currently Community & Collection homepage information is HTML-based and is stored in metadata that is appropriate for a minor subset of information (like the title) but it is better to move large/rich text to bitstreams.  
   2. Proposal here is to consider storing HTML-based markup (for Site, Community & Collection homepages) in Bitstream(s) associated with the object in question.  May allow for more CMS-lite behavior in the future
   3. Timeline for this is uncertain.  Possibly in 7 or 8. May depend on how/whether it can be scoped.
5. Concurrency in DSpace 7 (or 8).  What do we want to do when multiple editors are editing the same object?  Needs further analysis regarding implementation details
   1. We've decided (in meeting on March 7, 2019) to use ETags to implement concurrency. REST Contract notes on ETags: https://github.com/DSpace/Rest7Contract#etags--conditional-headers
   2. ETags only update of the two fields match. If someone edits first, your edit would fail and you would get a fail response (422?)
   3. ETags seems to have broader support in other REST APIs.  Recommended also by both Art and Andrea.

Notes