Date 25 Aug 2022
Call-in Information Time: 10:00 am, Eastern Time (New York, GMT-04:00)
Attendees Indicating note-taker
Georgy Litvinov Dragan Ivanovic Brian Lowe William Welling Benjamin Gross Agenda Publishing the VIVO 1.13.0 release Publishing a release candidate 3 Done Testing the release candidate for release candidate only new fixes should be tested https://github.com/vivo-project/Vitro/pull/321 https://github.com/vivo-project/Vitro/pull/322/files https://github.com/vivo-project/VIVO/pull/3734 Wiki page - Release Testing - 1.13.0 deployment of VIVO and Vitromvn clean install GoogleFormsStandard tests - https://forms.gle/cqk3oK7UmJpDWGYt8 Special focus on the new features - https://docs.google.com/forms/d/19FMslvvSzg_FK-Wmxg4t7EOP2UDft4FVdQvM4-2IO50/edit?usp=sharing Advanced tests - https://forms.gle/ZZLeVdBuDFMEMTGM https://vivo.tib.eu/vivo113rc VIVO 1.13.0 Technical DocumentationWiki space - VIVO 1.13.x Documentation Adding of technical documentation for:Deletion of individuals done Installing VIVO Release Notes updated Publishing VIVO 1.13.0 VIVO-solrhttps://github.com/vivo-project/vivo-solr/pull/6 Reviewing old PRs (<2021)https://github.com/vivo-project/VIVO-languages/pulls (4)https://github.com/vivo-project/Vitro/pulls (10)https://github.com/vivo-project/VIVO/pulls (10) Improvement of GitHub code management bug report template VIVO DSpace feature request template VIVO DSpace task definition template for upgrading dependencies, mitigation of security vulnerability is that a good practice? https://github.com/golang/go/issues/new/choose https://github.com/microsoft/repo-templates/blob/main/shared/SECURITY.md https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/configuring-issue-templates-for-your-repository https://github.com/DSpace/DSpace/issues/new/choose pull request template VIVO DSpace GitHub actions list of actions VIVO DSpace build.yml VIVO DSpace codecov alternatives - codeclimate, etc. separation of unit and integration tests docker.yml VIVO DSpace label merge conflicts yml DSpace adding new issue to project board yml DSpace Issues should be added for instance in a dedicated VIVO backlogs project board for triage (similarly as DSpace Backlogs - https://github.com/orgs/DSpace/projects ) codeQL analysis VIVO continues security analysis - LGTMhttps://lgtm.com/projects/g/vivo-project/Vitro/?mode=list labels list of labels VIVO DSpace assignment of labels to issuesVIVO DSpace Notes Draft notes on Google Drive
PR - Vitro 326 and VIVO 3745 One line change fixing email example settings Publishing the VIVO 1.13.0 release Publishing a release candidate 3 for VIVO Done. RC for VIVO languages is still on #1, RC-2 for Vitro. Testing the release candidate for release candidate only new fixes should be tested https://github.com/vivo-project/Vitro/pull/321 (Issue/vivo 3606 : add language-specific sorting and label fields to search index) https://github.com/vivo-project/Vitro/pull/322/files (fix: use public description in data property template model) https://github.com/vivo-project/VIVO/pull/3734 (Privilages for editing grant contributors) Another PR https://github.com/vivo-project/Vitro/pull/325 to fix property type for use with reconciliation services Dragan considering rolling these changes into RC-3. Not exactly right.. Might create RC-4. Question on OpenRefine from Brian Should this be on by default?! See example.runtime.properties: https://github.com/vivo-project/VIVO/blob/main/home/src/main/resources/config/example.runtime.properties#L414 Big question… does this service honor visibility settings?! Easily solution is to comment out the defaultTypeList setting Perhaps add note to upgrade notes that encourages users to review enabled services in runtime.properties VIVO 1.13.0 Technical Documentation Wiki space - VIVO 1.13.x Documentation Adding of technical documentation for: Deletion of individuals done Installing VIVO Release Notes Updated by Dragan Publishing VIVO 1.13.0 VIVO-solr https://github.com/vivo-project/vivo-solr/pull/6 Brian suggested rolling vivo-solr back into main VIVO project Georgy disagrees. It doesn’t interact with VIVO app at all. Also Elasticsearch is an option Don’t want to delay new VIVO release with this discussion What was the original purpose of separating this out? Similar to VIVO and Vitro languages? Makes it much more difficult to work with source code. One argument for separate repo, encourages contributions without ‘scary’ Vitro code If we combine, won’t be for this release Reviewing old PRs (<2021) https://github.com/vivo-project/VIVO-languages/pulls (4) https://github.com/vivo-project/Vitro/pulls (10) https://github.com/vivo-project/VIVO/pulls (10) Proposal - if no response to requests for changes, close a pull request after a certain number of months (5 or 6?) How do we review in general language-based PRs when we don’t speak the language? In some cases we just have to trust the PR submitter. Brian agrees with Benjamin that closing very old PRs is a good idea… they can always be reopened.
Request from Dragan: review and merge the new PRs ASAP so we can push out a new RC!
Actions Previous actions