Time: 11:00 am, Eastern Daylight Time, or 4:00 pm, Central European Time
Join Zoom Meeting
https://lyrasis.zoom.us/j/81398228834?pwd=SE0wdFN3NnFVbEhYVUhuM3BtQmVUQT09
Meeting ID: 813 9822 8834
Passcode: 728426
Indicating note-taker
Responsive wilma theme
Team decided to revert PRs related to making the Wilma theme responsive, to create a new one PR which will fix some meanwhile noticed issues with this theme.
The PR https://github.com/vivo-project/VIVO/pull/3932 was reverted by using a GitHub option.
Due to some conflict, PRs https://github.com/vivo-project/VIVO/pull/3909, https://github.com/vivo-project/Vitro/pull/429 could not be automatically reverted by using GitHub. Georgy will try to make revert PRs for those. Dragan will review and merge those PRs created by Georgy. Dragan will inform Milos (the author of PRs) to cherry pick commits and create new PRs (one for VIVO and one for Vitro). The next steps will be to test it and to fix issues.
I forgot my password
https://github.com/vivo-project/VIVO/pull/3916
https://github.com/vivo-project/Vitro/pull/421
Georgy and William will review this PRs pair. Ivan reported that some i18n messages have been changed, Dragan suggested validating those messages by native speakers after reviewing PRs by Georgy and William.
Role based search filters
https://github.com/vivo-project/Vitro/pull/442
The second reviewer for this PR will be William. In the case, William can’t find time to review this in the next couple of weeks, an alternative reviewer might be Ivan.
Profile linking with Matching ID doesn't work
https://github.com/vivo-project/VIVO/pull/3947
https://github.com/vivo-project/Vitro/pull/444
Dragan will review this again. However, a second reviewer is needed for reviewing the code of this PR for sure.
SPARQL authorization cache
https://github.com/vivo-project/Vitro/pull/450
Dragan thinks the second reviewer for this PR is not needed and will suggest merging of this PR with one reviewer in the #committers channel. If there is no objection, it might be merged (NOTE 1: only the last commit is new in this PR, which changed one java file and adding a JUnit test
NOTE 2: this PR has to be merged after merging https://github.com/vivo-project/Vitro/pull/444)
Object property statement can't be hidden from display without hiding all property statements in individual profile
https://github.com/vivo-project/Vitro/pull/451
Dragan thinks the second reviewer for this PR is not needed and will suggest merging of this PR with one reviewer in the #committers channel. If there is no objection, it might be merged.
Menu pages can't be modified
https://github.com/vivo-project/Vitro/pull/452
Dragan tested this PR, after reviewing the code he will report back to Georgy (author of the PR)
Date time interval doesn't allow end date to be equal start date
https://github.com/vivo-project/Vitro/pull/453
Dragan thinks the second reviewer for this PR is not needed and will suggest merging of this PR with one reviewer in the #committers channel. If there is no objection, it might be merged.
TinyMCE
https://github.com/vivo-project/Vitro/pull/454
Dragan will test and review the code.
JQuery
https://github.com/vivo-project/VIVO/pull/3955
https://github.com/vivo-project/Vitro/pull/449
This PR is complicated for testing and reviewing. Benjamin explained the process he applied in the implementation of this PR. It is already at a development server for one VIVO instance, meaning it is at least partially tested. The issue is whether it is working for all themes. Georgy suggested to split PR into:
At the end, we can in one minor VIVO release announce that usage of old jquery is deprecated, and in the next minor VIVO release we can remove old jquery.
Benjamin switched PR to draft, and he will wait to inform him once responsive wilma theme PR is merged to start making PRs.
Research areas
Georgy explained there is the option in Researchers profile pages (or Work pages) to manage research areas, and there is the option to create new or select an existing concept. Dragan will reply to the email with this explanation.