Tim Donohue [9:52 AM] @here: Reminder that at the top of the hour is our DSpace 7 Working Group meeting. This week it will be in Slack again (starting in #angular-ui for Angular team updates, and then in #rest-api for REST team updates). As always notes will be posted to https://wiki.duraspace.org/display/DSPACE/DSpace+7+UI+Working+Group Tim Donohue [10:00 AM] @here: Welcome all to the weekly DSpace 7 Working Group meeting. As our Angular team lead, @art-lowel, is still on holiday in Australia (hope he's having fun!), I'll lead the Angular team updates for today.
[10:00] First off, here's the Angular Team waffle board of tasks (current and upcoming): https://waffle.io/DSpace/dspace-angular
[10:01] There's not a ton of updates this week, but there is one *very important one*...namely, @wwelling has been working hard to update our Angular UI to Angular 4 (latest version)
[10:01] Specifically see this PR: https://github.com/DSpace/dspace-angular/pull/123 [10:02] And I see that both @atarix83 and @sulfrian have already been reviewing the code and providing feedback. Thanks!
[10:03] As noted at OR2017 (for those who were there), this is an important effort to get us up to date on the latest version of Angular (and simplify some areas of our codebase) [10:03] @wwelling : is there anything else you wanted to note about this? Do we just need a few more final reviews/tests, or is there more work outstanding on this ticket?
William Welling [10:04 AM] Sure
[10:05] I just finished fixing all the lint errors and am debugging the pagination issue we are discussing on the pull request. Tim Donohue [10:05 AM] Yes, I see you stumbled on the (known) pagination bug ticket: https://github.com/DSpace/dspace-angular/issues/103 [10:05] So, is the plan to possibly fix the pagination issue in this same PR? Giuseppe Digilio [10:06 AM] the problem is different from that issue William Welling [10:07 AM] Yeah, not the same issue. New issue, is likely to be due to dependency upgrades. Tim Donohue [10:07 AM] Oh, I see now (sorry, still catching up on the recent comments in the PR: https://github.com/DSpace/dspace-angular/pull/123) William Welling [10:07 AM] Will have it resolved shortly. Tim Donohue [10:07 AM] Ok, sounds great
[10:08] So, once this PR is ready for a re-review, @wwelling , can you let us know (either via GitHub or Slack, either works)? Then we can see if others can give it another review/test so we can get this work merged quickly (if possible) (edited) William Welling [10:09 AM] Yep Tim Donohue [10:09 AM] Thanks again! [10:10] So, looking again at our Waffle board (https://waffle.io/DSpace/dspace-angular)... the highest priority right now is to definitely get us upgraded to Angular 4 [10:10] So, any help reviewing/testing the final PR would be appreciated (once it is ready) [10:11] Our "Ready" column is looking a little light...there's a few tasks there to pick up. But, I'm also going to move over a few other known bugs (from Backlog) that were discovered just before or at OR2017. [10:11] namely https://github.com/DSpace/dspace-angular/issues/122 and https://github.com/DSpace/dspace-angular/issues/121 Waffle APP [10:12 AM] *Tim Donohue* moved DSpace/dspace-angular#122 from *Backlog* to *Ready (to be worked on)* #122 the community page shows all the collections instead to show only its child collections Column ---------------- Ready (to be worked on)
Open in Waffle [10:12] *Tim Donohue* moved DSpace/dspace-angular#121 from *Backlog* to *Ready (to be worked on)* #121 Detail page for an item without fulltext is broken Column ---------------- Ready (to be worked on) Open in Waffle Tim Donohue [10:12 AM] And there's the tickets I just moved over :wink: [10:14] there also are a few pagination bugs listed in the backlog I see.... #120 and #124. If anyone wants to move these forward while we are talking pagination issues, I'm OK with it as well
[10:14] So, I'll put them in "Ready" too Waffle APP [10:14 AM] *Tim Donohue* moved DSpace/dspace-angular#120 from *Backlog* to *Ready (to be worked on)* #120 The pagination component lists explicitly all the pages Column ---------------- Ready (to be worked on)
Open in Waffle [10:15] *Tim Donohue* moved DSpace/dspace-angular#124 from *Backlog* to *Ready (to be worked on)* #124 Refresh or deep linking to page of pagination not supported Column ---------------- Ready (to be worked on)
Open in Waffle Tim Donohue [10:15 AM] And #124 *might* be directly related to https://github.com/DSpace/dspace-angular/issues/103 [10:16] So, we now have a few more tasks in the "Ready" column for this week (for anyone who is looking for ways to contribute). I'll gladly add more tasks into the "Ready" as needed (just ping me if necessary), but these seem like a good area of concentration [10:18] Are there any other updates and/or questions that anyone else would like to share here? Tiago Ferreira [10:18 AM] Great Tim! Me and Neki's team are going to take a look on the board an d see what we can work on Giuseppe Digilio [10:19 AM] some issue like https://github.com/DSpace/dspace-angular/issues/91 should be done after angular upgrade is completed I think
Tim Donohue [10:20 AM] Oh, welcome @tiago.ferreira! I missed that you had joined us. For everyone else, Tiago is at Neki, one of our Brazilian service providers. They are hoping to get more involved in DSpace 7. So, we welcome your involvement, @tiago.ferreira and let us know if you have questions! (Slack or GitHub are often the best places to ask questions in between meetings)
[10:21] @atarix83 : I agree. the highest priority right now is to finish up the Angular 4 upgrade (and get it merged). Once that is merged, the stuff in the "Ready" column should be done based on Angular 4
[10:21] (but in the meantime, individuals are welcome to start looking at what is in the Ready column, etc to prepare any work)
William Welling [10:22 AM] Pull request will be ready for review soon. Hopefully before lunch. Tim Donohue [10:22 AM] Thanks again for all the hard work you've put in on this, @wwelling! Glad to hear it'll be ready soon
[10:23] Ok, any last questions or updates for the Angular UI team? (If not, we can move over to updates from the REST API team shortly) Tiago Ferreira [10:23 AM] Thanks and wish we can join the effort as quick as possible Tim Donohue [10:25 AM] Ok, I'm not seeing anyone typing, so I'll assume that's all for Angular UI updates. As a reminder, we will now all switch over to the #rest-api channel, and get updates from the REST API subteam
[10:25] So, I'll see you over in the #rest-api channel |