This Confluence wiki site, maintained by DuraSpace prior to the recent merger with LYRASIS, will transition from the duraspace.org domain to the lyrasis.org domain on Saturday, Nov 16 beginning at approximately 7pm ET. A period of downtime of 2-3 hours is expected. After the transition, this wiki will be available at https://wiki.lyrasis.org/. All links to duraspace.org wiki pages will be redirected to the correct lyrasis.org URL. If you have questions prior to or following the transition please contact: wikihelp@lyrasis.org.

Page tree
Skip to end of metadata
Go to start of metadata

Date

NO MEETING ON August 15.  Instead, all developers please update your status in the "Current Work" section below!  Feel free to add PRs needing attention/review, etc.  We will next meet on Thursday, August 22.

Attendees

Current Work

Legend for status icons

(blue star) = Highest Priority tasks (please prioritize these reviews/tasks over others). Currently this lists tasks/features that need to be completed for Preview Release.

(error) = review done (this week), changes were requested.

(tick) = review done, approved.

(warning) = review done, merge conflict or other minor changes requests

Tickets / PRs In Progress

  1. (Angular) Adding Accessibility via Travis CI  https://github.com/DSpace/dspace-angular/pull/356 (work in progress) (Lower priority)
  2. (warning) (Angular Bug) https://github.com/DSpace/dspace-angular/issues/368 ( Art Lowel (Atmire) )
  3. (REST Contract) Edit Homepage news: https://github.com/DSpace/Rest7Contract/pull/45 (Ben Bosman  - has outstanding questions/comments) (Lower priority)
  4. (REST) DS-4043: Revisit the security layer of the submission  (work in progress) Andrea Bollini (4Science)
  5. (warning) (REST Contract) Group and eperson management: https://github.com/DSpace/Rest7Contract/pull/41 (Waiting on updates fromBen Bosman )

PRs Needing Review

  1. (REST Contract) Collecting statistics - https://github.com/DSpace/Rest7Contract/pull/63 (Dimitris PierrakosAndrea Bollini (4Science) (warning) Feedback provided, Ben Bosman , (tick) Tim Donohue )
  2. (REST Contract) Update bitstream properties and format https://github.com/DSpace/Rest7Contract/pull/68 ((tick)Tim Donohue, Andrea Bollini (4Science)(warning) Feedback provided)
  3. (NEW) (REST Contract) DS-4317 bundles in REST https://github.com/DSpace/Rest7Contract/pull/72
  4. (NEW) (REST Contract) upload bitstream to archived item - update https://github.com/DSpace/Rest7Contract/pull/71
  5. (REST) Pagination bug with withdrawn items: https://github.com/DSpace/DSpace/pull/2406 (Dimitris Pierrakos , Ben Bosman - Feedback provided)
  6. (REST) implement upload bitstream to archived item https://github.com/DSpace/DSpace/pull/2473 (Tim Donohue - (warning) Feedback provided,  Andrea Bollini (4Science)- (warning) Feedback provided)
  7. (NEW) (REST) Issue when community has multiple dc.title values https://github.com/DSpace/DSpace/pull/2486 ((tick) Tim Donohue, NEEDS SECOND REVIEWER)
  8. (Angular) (Entities) Deleting relationships: https://github.com/DSpace/dspace-angular/pull/402 (Paulo Graça - will test againTim Donohue )
  9. (Angular) Move Item Component: https://github.com/DSpace/dspace-angular/pull/335 (Giuseppe Digilio (4Science) (warning) reviewed and provided feedback, Tim Donohue - (warning) Feedback provided)
  10. (Angular) Item-Collection Mapper:  https://github.com/DSpace/dspace-angular/pull/348 (Tim Donohue - (warning) Feedback provided, NEEDS SECOND REVIEWER)
  11. (Angular) Shibboleth integration support: https://github.com/DSpace/dspace-angular/pull/429  (Julius running into an error with 'yarn start' only) (Giuseppe Digilio (4Science) feedback provided, Fernando FCT/FCCN, Paulo Graça )
  12. (Angular) Submission Miscellaneous fixes: https://github.com/DSpace/dspace-angular/pull/432 (Art Lowel (Atmire) will re-review, Julius Gruber )
  13. (Angular) UI Language Cookie https://github.com/DSpace/dspace-angular/pull/443 ((tick) Tim Donohue, Paulo Graça)
  14. (Updated) (Angular) Convert i18n files to JSON5 format https://github.com/DSpace/dspace-angular/pull/439 (Tim DonohueNEEDS SECOND REVIEWER)
  15. (NEW) (Angular) Search Performance optimizations #2 https://github.com/DSpace/dspace-angular/pull/437 (NEEDS REVIEWERS)
  16. (NEW) (Angular) bitstream format registries https://github.com/DSpace/dspace-angular/pull/455 (Tim DonohueArt Lowel (Atmire)(warning) reviewed and provided feedback)
  17. Indirect entity refs during CSV import https://github.com/DSpace/DSpace/pull/2471 (Ben Bosman, Tim Donohue )
  18. (Backend) Solr 7 fixes for upgrading to DSpace 7 https://github.com/DSpace/DSpace/pull/2393 (NEEDS REVIEWERS)

PRs Merged this week!

  1. (tick) (Angular) Disable e2e tests in travis https://github.com/DSpace/dspace-angular/pull/454
  2. (tick) (Angular) flatten i18n files https://github.com/DSpace/dspace-angular/pull/457
  3. (tick) (Angular) Edit current item query https://github.com/DSpace/dspace-angular/pull/440

Blocked

  1. (Blocked PRs go here)

Delayed / Needs Discussion

  1. (REST) Scripts & Processes endpointhttps://github.com/DSpace/Rest7Contract/pull/17
    1. How do we move this forward? In our Jan 24 meeting, Tim noted a risk of "scope creep" with this feature suggestion. This idea has been tabled since then.
    2. In July 25 meeting, Atmire said they'd come back with notes on the proposed backend implementation.
  2. Managing Authorization info in Angular UIHow to pass Authorization rights (i.e. logged in user's access rights) from REST API to Angular?  See for example: https://github.com/DSpace/dspace-angular/issues/393
    1. Can this be achieved via passed HAL "_links" (e.g. the existence of an "edit" link in REST response means you must have Edit rights)?
    2. In July 25 meeting, we noted this probably cannot be resolved with just one simple solution. May need to look at different options for different scenarios
      1. Also likely to need to store/cache a user's Groups in UI layer, as some areas (e.g. Administrative) require knowledge of user group membership
  3. Initial Performance Testing from Chris.
    1. https://cwilper.github.io/dspace-perftest/
  4. (REST Contract) Edit Homepage News: https://github.com/DSpace/Rest7Contract/pull/45
    1. Delayed until after Preview release. General agreement (in meeting on March 21, 2019) that storing HTML in metadata fields is not really ideal behavior.  Metadata (from a librarian standpoint) tends to be free of format-related markup (as that allows for easier sharing, understanding of metadata.  Currently Community & Collection homepage information is HTML-based and is stored in metadata that is appropriate for a minor subset of information (like the title) but it is better to move large/rich text to bitstreams.  
    2. Proposal here is to consider storing HTML-based markup (for Site, Community & Collection homepages) in Bitstream(s) associated with the object in question.  May allow for more CMS-lite behavior in the future
    3. Timeline for this is uncertain.  Possibly in 7 or 8. May depend on how/whether it can be scoped.
  5. Concurrency in DSpace 7 (or 8).  What do we want to do when multiple editors are editing the same object?  Needs further analysis regarding implementation details
    1. We've decided (in meeting on March 7, 2019) to use ETags to implement concurrency. REST Contract notes on ETags: https://github.com/DSpace/Rest7Contract#etags--conditional-headers
    2. ETags only update of the two fields match. If someone edits first, your edit would fail and you would get a fail response (422?)
    3. ETags seems to have broader support in other REST APIs.  Recommended also by both Art and Andrea.
  6. Not discussed much, but could there be opportunities to use Travis CI + Docker Compose for testing of Angular??

Notes