Page History

...

• (15 mins) Developer Stand Up - Developers give brief updates on their effort (or their team's effort).

  • Update/see "Current Work" section below based on your status. Please feel free to update prior to meeting.
  • Please highlight any new work (needing reviews/testing), any blockers (for you), and any discussion topics you may have.
• (30 mins) General Discussion Topics
  
  1. Solr upgrade effort.  When to merge?  Once the initial Solr PR#2265 PR#2058 is merged, all developers will need to install/setup their development DSpace with an external Solr. 
  2. Concurrency in DSpace 7 (or 8).  What do we want to do when multiple editors are editing the same object?
     1. REST Contract notes on ETags: https://github.com/DSpace/Rest7Contract#etags--conditional-headers
     2. REST PATCH method also defines a "test" operation: https://tools.ietf.org/html/rfc6902#section-4.6 , however we do not yet support it in the REST API
  3. DSpace 7 Preview Release (per Steering discussions yesterday) New deadline end of March (Beta before OR2019)
     1. Perform preview release on a separate branch (not master) to allow for code that is still undergoing final review?  (proposed by Lieven & Pascal)
     2. Preview Release made available via Docker? (proposed by Pascal)
• (15 mins) Planning for next week
  
  • Assigning PRs for Review
  • Next tasks from Development Planning Spreadsheet

...

Tickets / PRs In Progress

...

1. (Angular) Context sensitive admin menus (Art Lowel (Atmire) ) (work in progress)  (Timeline: Should be ready by Feb 28)
2. (Angular) Adding Accessibility via Travis CI  https://github.com/DSpace/dspace-angular/pull/356 (work in progress) (Lower priority)
3. (Angular) MyDSpace UI (work in progress) (Timeline: Should be ready by Feb 28)
4. (REST Contract) Edit Homepage news: https://github.com/DSpace/Rest7Contract/pull/45 (Ben Bosman) (Updates requested from Tim & Andrea) (Lower priority)(REST) Workflow Endpoint: https://github.com/DSpace/DSpace/pull/2312 (Andrea Bollini (4Science) - EARLY Reviews Needed. Reviewers:  Tim Donohue , Ben Bosman Hibernate issues with integration tests.) (Timeline: Should be ready by Feb 21Additional input has been included, requires new review from Tim Donohue  & Andrea Bollini (4Science) ) (Lower priority)
5. (REST) MyDSpace Endpoint (Andrea Bollini (4Science) - EARLY Reviews Needed. Reviewers: Ben Bosman , Tim Donohue  (IT missings - previous Discover IT fixed ) on the 4Science repo against the 2312 PR https://github.com/4Science/DSpace/pull/65 (Timeline: Should be ready by Feb 28 , maybe before exact date t.b.c on 18th )
6. (REST) Updating Owning Collections: https://github.com/DSpace/DSpace/pull/2283 (Kevin Van de Velde (Atmire)  - changes requested. Implementation doesn't align with contract) (Timeline: Should be ready a week after the entities are merged)
7. (Backend) One Webapp Backend - Initial PRREST) Item Mapper functionality: https://github.com/DSpace/DSpace/pull/2265 (Tim Donohue ) (work in progress)

PRs Needing Review

1. 2282  (Kevin Van de Velde (Atmire)  - changes requested. Implementation doesn't align with contract) (Timeline: Should be ready a week after the entities are merged)
2. (Backend) One Webapp Backend - Initial PR:(REST Contract) Mapping Collection (UPDATED) https://github.com/DSpace/Rest7ContractDSpace/pull/522265 (Andrea Bollini (4Science) - approved, Ben Bosman - NEEDS re-review)Tim Donohue ) (work in progress)

PRs Needing Review

1.  (REST Contract) Group and eperson management: https://github.com/DSpace/Rest7Contract/pull/41 (Andrea Bollini (4Science) - Reviewed & added questions/feedback,  Tim Donohue - Reviewed & added questions/feedback)
2.  (REST Contract) Endpoint for EPerson profile PATCH requests: https://github.com/DSpace/Rest7Contract/pull/49 (UPDATED PR - Andrea Bollini (4Science) minor changes requested, Paulo Graça  minor changes requested)
3.  (REST Contract) Manage Metadata RegistryPATCH support: https://github.com/DSpace/DSpaceRest7Contract/pull/229146 (Paulo Graça - had questions, Tim Donohue - approved, Paulo Graça and Andrea Bollini (4Science) ) - approved)
4. (REST) Workflow Endpoint: https://github.com/DSpace/DSpace/pull/2312 (Tim Donohue , Ben Bosman Integration tests have been added, latest set to be added by the end of day Feb 21) 
5.  (REST) Metadata as a Map: https://github.com/DSpace/DSpace/pull/2287 (Approved / ready to be merged, but related to should be merged same time as next PR #347)
6. (Angular) Metadata as a Map: https://github.com/DSpace/dspace-angular/pull/347 (Giuseppe Digilio (4Science)minor changes requested and implemented. Paulo Graça - approved )
7.  (Angular) Modifying Metadata Registries: https://github.com/DSpace/dspace-angular/pull/355 (Paulo Graça- approved - new DS-4170 to address usability issues. Tim Donohue - minor changes requested)
8. (Angular) Submission implementation: https://github.com/DSpace/dspace-angular/pull/279  (Art Lowel (Atmire) , Paulo Graça , Tim Donohue  all received suggestion applied, ready to be merged after approval)
9. (Angular) Administrative Item Edit: https://github.com/DSpace/dspace-angular/pull/362 (Paulo Graça, , this PR achieves the expected result but also presents some Usability issues. Tim Donohue)
10. (Angular) Browse -By links in NavBar & Pagesby date and Starts-With component: https://github.com/DSpace/dspace-angular/pull/360364 (Paulo Graça, Tim Donohue)
11. (Backend) Upgrading Solr Server for DSpace - Initial PR: https://github.com/DSpace/DSpace/pull/2058 (NEW PR - Terrence W Brady , Kim Shepherd , Art Lowel (Atmire))
    1. Might have an impact on MyDSpace PR (See "In Progress" section)?
       
       

PRs Merged this week!

1.  (first PR goes here)

BLOCKED

1.  (REST Contract) Mapping Collection: https://github.com/DSpace/Rest7Contract/pull/52
2.   (REST) Manage Metadata Registry(REST) Item Mapper functionality: https://github.com/DSpace/DSpace/pull/2282Blocked by Contract #52/2291
3.  (Angular) Browse-By links in NavBar & Pages: https://github.com/DSpace/dspace-angular/pull/360

BLOCKED

1. (REST) EPerson profile PATCH functionality : https://github.com/DSpace/DSpace/pull/2257
   1. Blocked by Contract #49
2. (Angular) Move Item Component: https://github.com/DSpace/dspace-angular/pull/335
   1. Blocked by DSpace PR#2283
3. (Angular) Item-Collection Mapper:  https://github.com/DSpace/dspace-angular/pull/348
   
   1. Blocked by Contract #52Blocked by DSpace PR#2282

Delayed / Needs Discussion

1. (REST) Scripts & Processes endpoint: https://github.com/DSpace/Rest7Contract/pull/17
2. Discussion of deletion of EPeople for GDPR compliance (from Pascal)
   1. https://github.com/DSpace/DSpace/pull/2229. NOTE: item.getSubmitter() will return null if EPerson deleted.

Notes

• Discussion Topics
  • Tim notes that Heather Greer Klein will soon be joining the effort as a part-time DSpace 7 Product Manager (8 hours per week, until DSpace 7 is released). She'll help with planning tasks, liaison with Marketing, etc.
    
    • She's on vacation today, but hopefully will be able to attend next week's meeting.
  • Preview Release Discussion
    • Steering discussed yesterday and decided to move forward with Preview Release. It's an important deadline, both for marketing as well as for ensuring we're "on schedule" for OR2019.
    • Preview Release new deadline is end of March
    • Beta Release in time for OR2019.
    • Perform preview release on a separate branch (not master) to allow for code that is still undergoing final review?
      
      • Art: seems ok, but we need to be more conservative than we were before OR2018. Nothing could go on this branch that isn't nearly complete.
      • Andrea: Agrees with Art around OR2018 issues.  Against this idea overall
      • This was discussed in Steering as a "backup plan". End goal is still to try and get everything on "master", but if we are running late, the decision becomes:  Do we push back Preview Release again (has risk that we miss Beta by OR2019), or do we cut the release with some "partially reviewed" features/code?
      • Consensus: We cannot decide this today. Likely this needs to go to an email vote.
      • Not high priority as this is a backup plan, but we do need to have a backup plan if Preview Release deadline of end of March starts to "slip"
  • Solr Upgrade Discussion
    • When do we merge?  The code passes all ITs and is in review stage. It will affect all developers, as they will need to install a separate Solr (Mark W notes that's not hard)
    • No user facing improvements though
    • Consensus: This is a "nice to have" for Preview Release, but not required.  It's third priority behind Submission/Workflow & Configurable Entities.  If it misses Preview (or cannot be tested sufficiently before then) we should merge this just after Preview
  • Concurrency in DSpace 7 (or 8).  What do we want to do when multiple editors are editing the same object?
    • Some implementation options on REST API side:
      • REST Contract notes on ETags: https://github.com/DSpace/Rest7Contract#etags--conditional-headers
      • REST PATCH method also defines a "test" operation: https://tools.ietf.org/html/rfc6902#section-4.6 , however we do not yet support it in the REST API
    • We don't have enough information to make a decision here.  It sounds more and more like this might need to wait for DSpace 8 (low priority for DSpace 7).  However, Atmire will analyze whether there is a "quick fix" or quick solution and report back.