Page History

...

• (15 mins) Developer Stand Up - Developers give brief updates on their effort (or their team's effort).

  • Update/see "Current Work" section below based on your status. Please feel free to update prior to meeting.
  • Please highlight any new work (needing reviews/testing), any blockers (for you), and any discussion topics you may have.
• (30 mins) General Discussion Topics
  
  1. Solr upgrade is ready to merge (already at +2).  Is everyone ready? https://github.com/DSpace/DSpace/pull/2058
     1. This will affect developers (everyone needs to install Solr)
     2. This will also affect the demo REST API (next time it is updated)
  2. Finalizing the Workflow REST Endpoint PR: https://github.com/DSpace/DSpace/pull/2312/  Several key changes to the existing Discovery/Solr functionality.
     1. Creates a new interface "BrowsableObject" to represent anything indexable by Discovery/Solr (this used to require an object being an official `DSpaceObject`)
        1. Possibly rename to "IndexableObject" (i.e. it's an object that can be indexed)
     2. Adds new Constants for object types "WORKSPACEITEM", "WORKFLOWITEM", "WORKFLOW_POOL", "WORKFLOW_CLAIMED".  These are NOT DSpaceObjects, but are new BrowsableObjects (as they will be indexed in Discovery for the MyDSpace & Workflow user interface)
        1. Possibly rename "WORKFLOW_POOL" to "TASK_POOL" and "WORKFLOW_CLAIMED" to "TASK_CLAIMED"
        2. We don't need to index the ITEM individually when indexing the WORKSPACEITEM or WORKFLOWITEM (Andrea believes this to be true)
     3. Changes the Discovery REST response format slightly – it no longer returns "dspaceObject", but now returns "resultObject" (as not all results are DSpaceObjects)
  3. (tentative. lower priority) Edit Homepage News: https://github.com/DSpace/Rest7Contract/pull/45
     1. Reporting back on implementation suggestions/ideas.  Do we implement as metadata on the Site object (similar to Community/Collection news sections)?
  4. (add a discussion topic)
• (15 mins) Planning for next week
  
  • Assigning PRs for Review
  • Next tasks from Development Planning Spreadsheet

...

...

1. (Angular) Adding Accessibility via Travis CI  https://github.com/DSpace/dspace-angular/pull/356 (work in progress) (Lower priority)
2.  (Angular) MyDSpace UI (work in progress) (Timeline: Should be ready by Feb 28, delayed  5th March, delayed  12th March due to sub optimal Search implementation, need to run against the updated MyDSpace REST API PR - Blocked until discussion around the MyDSpace Endpoint is solved see 2312 and  https://github.com/4Science/DSpace/pull/65)
3. (REST Contract) Edit Homepage news: https://github.com/DSpace/Rest7Contract/pull/45 (Additional input has been included, requires new review from Tim Donohue  & Andrea Bollini (4Science) reviewed blocking concernsBen Bosman  - has outstanding questions/comments) (Lower priority)
4.  (REST) MyDSpace Endpoint (Andrea Bollini (4Science) - EARLY Reviews Needed. Reviewers: Ben Bosman , Tim Donohue  (everything in place, first review comments answered, ITs provided on the 3rd March ) on the 4Science repo against the 2312 PR https://github.com/4Science/DSpace/pull/65
5. (REST) Updating Owning Collections: https://github.com/DSpace/DSpace/pull/2283 (Kevin Van de Velde (Atmire)  - changes requested. Implementation doesn't align with contract) (Timeline: Should be ready a week after the entities are merged)
6. (REST) Item Mapper functionality: https://github.com/DSpace/DSpace/pull/2282  (Kevin Van de Velde (Atmire)  - changes requested. Implementation doesn't align with contract) (Timeline: Should be ready a week after the entities are merged)

PRs Needing Review

1.  Configurable Entities PRs for Angular & REST (coming soon from DSpace 7 Entities Working Group (2018-19)) (REST Contract) Group and eperson management: 
   1. https://github.com/DSpace/DSpace/pull/2331 (blocking PR to master)
   1. https://github.com/DSpace/
   Rest7Contract
   1. dspace-angular/pull/
   41
   1. 354 (
   Waiting on updates from Ben Bosman )
   1. blocking PR to master)

PRs Needing Review

1.  (REST Contract) Group and eperson management(REST) Metadata PATCH support: https://github.com/DSpace/DSpaceRest7Contract/pull/2313 (ensure alignment with merged Contract PR#46) (Paulo Graça - approved, Tim Donohue 41 (Waiting on updates from Ben Bosman )
2.   (REST) Workflow Endpoint: https://github.com/DSpace/DSpace/pull/2312 (Tim Donohue , Ben Bosman Re-reviewed and additional feedback added., All change requests implemented - answers provided also for latest feedbacks) 
3.  (REST) EPerson profile PATCH functionality : https://github.com/DSpace/DSpace/pull/2257 (Andrea Bollini (4Science) , Tim Donohue )(REST) Fix bug where CORS Headers missing when Exception thrown: https://github.com/DSpace/DSpace/pull/2208 (Paulo Graça ,   This PR currently has merge conflicts & has outstanding feedback from Tom Desair)
4.   Tim Donohue )(Angular) Submission implementation: https://github.com/DSpace/dspace-angular/pull/279  (Art Lowel (Atmire) , Paulo Graça - reviewed, Tim Donohue all received suggestion applied, ready to be merged after approval)
5.  (Angular) Browse by date and Starts-With component: https://github.com/DSpace/dspace-angular/pull/364 (Paulo Graça - approved, Tim Donohue - minor changes requested. Behavior questions added to PR)
6. . This PR has outstanding feedback (namely code comments) to be applied.)
7.  (Angular) (Angular) Transfer to .po message format - Initial PR: https://github.com/DSpace/dspace-angular/pull/366 (Paulo Graça - changes requested, Tim Donohue , Art Lowel (Atmire) )
   1. Even though not all keys are present yet, please provide feedback if this can be merged so we can stop new keys being added to the json format.
     - requested updates. Currently failing build.)
8.  (Angular) Context sensitive admin menus (Art Lowel (Atmire) )  menus  https://github.com/DSpace/dspace-angular/pull/367 (Paulo Graça - issue reported & response/fix made by Lotte, Tim Donohue - approved)
9. (Backend) One Webapp Backend - Initial PR: https://github.com/DSpace/DSpace/pull/2265 (Ben Bosman , Mark H. Wood )
   1. This PR will have a followup PR to rename the "dspace-spring-rest" webapp to "dspace-server" and update all URL configurations
10. (Backend) Upgrading Solr Server for DSpace - Initial PR: https://github.com/DSpace/DSpace/pull/2058 (Terrence W Brady , Kim Shepherd , Art Lowel (Atmire))
    1. Might have an impact on MyDSpace PR (See "In Progress" section)?

PRs Merged this week!

1. 1. Docker changes to merge after this PR is merged: https://github.com/DSpace-Labs/DSpace-Docker-Images/pull/96
2.  (Docker) https://github.com/DSpace-Labs/DSpace-Docker-Images/pull/95 (Art Lowel (Atmire))
3.  (REST Contract) Metadata PATCH support: 

   https://github.com/DSpace/

   Rest7Contract

   dspace-angular/issues/368 (Andrea Bollini (4Science), Giuseppe Digilio (4Science), Tim Donohue, Ben Bosman)

   1. Potentially a discussion item for next week.

PRs Merged this week!

1. pull/46 (REST Contract) Endpoint for EPerson profile PATCH requestsMetadata PATCH support: https://github.com/DSpace/Rest7ContractDSpace/pull/492313 
2.  (REST Contract) Fix examples for metadata-as-map ) Fix bug where CORS Headers missing when Exception thrown: https://github.com/DSpace/Rest7ContractDSpace/pull/53 2208
3.  (Angular) Administrative Item EditBrowse by date and Starts-With component: https://github.com/DSpace/dspace-angular/pull/362364
   
   1. Outstanding usability issues logged as tickets #369 and #370, and the related REST API bug logged at DS-4186

BLOCKED

1. (Angular) Move Item Component: https://github.com/DSpace/dspace-angular/pull/335
   1. Blocked by DSpace PR#2283
2. (Angular) Item-Collection Mapper:  https://github.com/DSpace/dspace-angular/pull/348
   
   1. Blocked by DSpace PR#2282

...

1. Submission & Workflow UI / backend
2. Configurable Entities (from DSpace 7 Entities Working Group (2018-19))
3. Upgrading Solr Server for DSpace (not required for Preview, as there's no user facing features. However, the earlier we feel comfortable merging this effort the better)

...