Versions Compared

Old Version 23

changes.mady.by.user Tim Donohue

Saved on

compared with

New Version 24

changes.mady.by.user Art Lowel (Atmire)

Saved on

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

  • Before firing a PR, always ensure your code works on the server (disable javascript in your browser and see if it still works) as well as the client, and that it works with the AoT build (npm start) as well as the webpack build (npm run watch:dev)
  • Keep adaptability in mind. An institution installing DSpace will often want to modify a few things about the UI. The easier we can make that, the better. Therefore keep your components small (divide them in to sub-components), make sub-modules for coherent functionality, use SASS variables, etc.
  • We agreed to remove the concept of Communities from the UI. They should be called Collections as well. The decision to remove the concept of Communities from the UI was reversed in the meeting of April 13th

Code Style

  • Follow the official Angular style guide. It contains guidelines for naming files, directory structure, etc.
  • TSLint can help you with that. It will run automatically whenever the code is rebuilt (even during a watch task) or you can run it manually with npm run lint

...