Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

How to contribute

Prerequisites

  • You'll need to be in the dspace-angular github team to get the required access. Send your github username to Art Lowel (Atmire) to get an invite.
  • Fork the repository on Github

Workflow

  • Have a look at the waffle board

  • Take an issue that’s in the ready section and has nobody assigned to it

  • assign yourself

  • When you start working on it, move the issue to the “in progress” section

  • Work on a separate branch for the issue on your fork

  • Add a link to the branch on your fork as a comment to the task on the waffle board. That way people can 
  • When you’re ready, fire a pull request

  • in the comments of the pull request, write something akin to “this PR connect’s to #{the ID of the issue}”. That way the issue will be moved automatically to the review column.

  • When at least two people have reviewed and approved your PR, it can be merged in master.

  • You can also help out by reviewing the pull requests of other people

  • Please keep an eye on your pull request afterwards, the reviewers may have questions or comments about it, or ask you to tackle things in a different way, before they can approve it

  • Most discussions about the task or the pull request can happen through the github & waffle board comments.

  • If it’s more complex you can bring it up in one of these meetings.

  • After your Pull Request has been merged, drag the issue to the done column on the waffle board. (this can also be automated by adding “this merge closes #{the id of the issue}” in the merge comment.

Learning Resources

General

Angular 2 Resources

...

Typescript

...

...

  • The concepts are explained clearly, though independently from angular in the main redux docs
  • There is also a great free video course on egghead
  • @ngrx is an implementation of Redux for Angular 2 using RxJS
  • Ducks is a way to structure redux applications to keep them as modular as possible that works well in practice.

How to contribute

 

Prerequisites

 

  • You'll need to be in the dspace-angular github team to get the required access. Send your github username to Art Lowel to get an invite.
  • Fork the repository on Github

 

 

 

Workflow

  • Have a look at the waffle board

  • Take an issue that’s in the ready section and has nobody assigned to it

  • assign yourself

  • When you start working on it, move the issue to the “in progress” section

  • Work on a separate branch for the issue on your fork

  • Add a link to the branch on your fork as a comment to the task on the waffle board. That way people can 
  • When you’re ready, fire a pull request

  • in the comments of the pull request, write something akin to “this PR connect’s to #{the ID of the issue}”. That way the issue will be moved automatically to the review column.

  • When at least two people have reviewed and approved your PR, it can be merged in master.

  • You can also help out by reviewing the pull requests of other people

  • Please keep an eye on your pull request afterwards, the reviewers may have questions or comments about it, or ask you to tackle things in a different way, before they can approve it

  • Most discussions about the task or the pull request can happen through the github & waffle board comments.

  • If it’s more complex you can bring it up in one of these meetings.

  • After your Pull Request has been merged, drag the issue to the done column on the waffle board. (this can also be automated by adding “this merge closes #{the id of the issue}” in the merge comment.