- 22.214.171.124 In supporting PUT to LDPRv in order to create a LDPRm, is this just included for server managed versions? Or is PUT to an LDPRv intended to be addressable separately from a LDPR so as to trigger this behavior?
- Propose that PUT language is removed and that server managed behaviors are left up to implementors so long as they meet other requirements
- 4.3.1 What is the default serialization for GET requests to LDPCv? The only required encoding is application/link-format.
- This will depend on if the LDPCv remains the same object as the timemap
- 4.3.5 What is the expected behavior if a POST to an LDPCv is made which specifies a Memento-Datetime that is already in use by an existing LDPRm for that LDPRv?
- Having two memento's with the same datetime would result in datetime negotiation yielding indeterminate results.
- Ignore request and return a 412 response? Delete and replace the existing version?
- This could be something we decide - perhaps the new one overwrites the existing one?
- Starting with a 412 response
- 4.5 Does the modeshape fcrepo currently have a server managed option for versioning?
- We need to make sure that a server managed scenario knows how to handle an LDPCv correctly - in that it doesn't version that resource if a user issues a PUT against it (as a user would if they want the original resource LDPRv to get versioned).
With Fedora API Specification:
- 4.1.1 Add HTTP header Link: rel="timegate" referencing itself
- versions will need to be accessible via the TimeGate, which is the LDPRv. The timemap will still include the regular path to the LDPRm.
- 126.96.36.199 include 'Vary: Accept-Datetime' header in response
- 4.2.3 When requesting a Memento or a TimeGate, a Link header must be returned with type of "original" which points to the URI of the original. See 2.2.1. Link Relation Type "original"
- 4.2.3 "Memento-Datetime" should be returned when making a GET against a memento, indicating the timestamp of the memento
- 188.8.131.52 The TimeMap link may include "from" and "until" attributes, do we want to provide these? See 2.2.3. Link Relation Type "timemap"
- 184.108.40.206 How is fedora going to handle Accept-Datetime negotiation? nearest version? nearest version before requested time? Or is it even going to be used this way? See 3.1. Datetime Negotiation (first paragraph after example steps)
- 4.3.5 Are we going to continue allowing the "slug" header on requests to create versions?
- It would be helpful to record which Datetime Negotiation pattern the modeshape implementation uses in documentation
With Memento Specification:
- 2.2.1 - noted above in 4.2.3: on a GET/HEAD request to a LDPRm or TimeGate (the LDPRv, in this case) a Link header must be returned with relation type of 'original' which points to URI of the original resource (LDPRv)
- 2.2.2 - on a GET/HEAD request to a LDPR or LDPRm, a Link header must be returned with the relation type of 'timegate', which points to the the timegate for the resource.
- multiple timegate Links are possible
- 2.2.3 - on a GET/HEAD request to a LDPR or LDPRm or TimeGate(which is the LDPR, in this case), a Link header must be returned with the relation type of 'timemap', which points to the timemap for the resource.
- support "from" and "until" attributes? These would cause the returned representation of the time map to only include the interval requested.
- the link should make use the 'type' attribute to indicate the mime type of the timemap.
LDPCv Example Response
Example Interactions to Version a Resource or a Tree
Note: if in example 2 the LDPRm were to have relationship:
</a/fcr:versions/20170919080311> ldp:contains </a/b/fcr:versions/20170919080311>
there would still be multiple parents containing
How does delete behave when multiple LDPRs (a LDPRv and a LDPRm) both ldp:contains the same child? What happens if you delete the LDPRm?
Handling Deletion of Referenced Resources / Mementos
Approach 1 - Prevent deletion
Approach 2 - Allow deletion, ignore referential integrity
Accept-Datetime Negotiation Example
1) If no Accept-Datetime is provided, then the LDRPv is returned
2) If Accept-Datetime is provided, then the nearest LDPRm with a Memento-Datetime < than requested time, or LDPRv with created time < than requested time is returned.
Immutable LDPRms and Relaxing Referential Integrity
Fcrepo/Memento defines a past version of a LDPRm (aka a memento) as a fixed representation of the original LDPR at the time the version was created. However, a memento can be incorrectly modified in the following scenario, given memento M of original resource O, and another resource R:
- M contains relation dc:related to R
- Delete resource R
- Modeshape automatically removes dc:related relation from M
- M no longer matches O at the time that M was created.
This is because modeshape fedora maintains referential integrity - if a resource is deleted, all references to that resource are removed as well.
To address this, requirements for referential integrity would be relaxed for mementos such that they could continue to refer to the deleted resource. This means that mementos could have triples that reference objects that no longer exist.
This would come with some implications:
- When restoring a LDPRm, references would become active again, meaning that they could then be subject to removal. There would likely need to be error reporting to inform clients of this.
- Need to determine what acceptable validation or outcomes would be for restoring when information could be lost.
Two options for how to handle this would include:
- When an LDPRm is created from an LDPRv, all references to modeshape nodes would be converted to URIs. Since they would no longer be node references, they would not be cleaned up.
- Instead of storing a LDPRm as a LDPRS, it could be stored as a RDF serialization of the LDPRS stored to a binary.
Versions will be of individual resources, versus tree snapshots
In Fedora 4, when a version of a resource is created, a snapshot of it and the entire tree of child resources it contains is captured. Moving ahead, the proposed design would instead only create a version of the requested resource, stopping there rather than versioning its child resources. The resource would be copied as it is and links to other resources would remain intact.
- Resource versions could now be managed individually, rather than creating unwanted trees, when the goal is only to version a single resource's metadata.
- Creating a snapshot of an entire tree would need to be triggered with many individual API requests.
- Retrieving or restoring a tree of resources to a particular point in time would require individual API requests with datetime negotiation.
- Creation and management of versions would shift from being a Modeshape-provided feature to the Fedora code base.
Add versioning response headers to LDPRv HEAD/GET responses -
The following headers should be added to responses to HEAD and GET requests to LDPRv's only when the resource is versioned (has the http://fedora.info/definitions/fcrepo#VersionedResource type):
- Vary: accept-datetime
- Include 'Link: rel="timegate"' referencing itself.
- Include 'Link: rel="timemap"' on versioned resource pointing to LDPCv.
- Since the LDPRv is also its own timegate, it must return an 'original' link header referencing itself
See Pattern 1.2 in https://tools.ietf.org/html/rfc7089#page-18 for details.
Support Datetime negiotation for LDPRvs
Implement support for datetime negotiation for the retrieval of previous versions of a resource as follows:
- GET requests to LDPRv URIs must support the 'Accept-Datetime' header
- It must follow the syntax outlined in https://tools.ietf.org/html/rfc7089#section-2.1.1
- When a 'Accept-Datetime' is provided:
- Must respond with a 302 status code and an empty body
- Response must contain 'Location' header containing the URI of the LDPRm or LDPRv that was negotiated
- Must contain all other standard LDPRm GET response headers
- When a datetime is provided, Fedora will respond with the past LDPRm chronologically nearest (min-past) to the given header as follows:
Add versioning headers for LDPRm HEAD/GET responses
Responses to LDPRm HEAD and GET requests must include headers as outlined below.
- Add HTTP header Link: rel="timegate" to the LDPRv
- Include 'Link: rel="timemap"' on versioned resource pointing to LDPCv
- add 'original' link header referencing LDPRv
- Add 'Memento-Datetime' header
Support OPTIONS request on LDPRms
Response to include header 'Allow: GET, HEAD, OPTIONS, DELETE'
Prevent modification requests to LDPRm
PATCH/POST/PUT requests should all return 405 responses
DELETE - If a resource is deleted from the repository, it appears as if all triples across the repository that have that resource as an object will get removed. Even in a versioned resource. According to the API spec, mementos need to be immutable. This particular behavior of cleaning up will have to change where mementos are concerned.
PUT requests to LDPRv (work in progress) If a Accept-Datetime is provided on a regular PUT request to an LDPRv A new LDPRm is created from the LDPRv The LDPRm will have a Memento-Datetime matching the provided Accept-Datetime Response includes 'Link: rel=timemap' pointing to LDPCv for versioned resources include 'Vary: Accept-Datetime' header in response If the LDPCv for the LDPRv does not already exist, then it will be created and contain the new LDPRm
POST request to LDPCv to create LDPRm
- if the request contained a body, then a new LDPRm is created from the submitted body
- if the request body was empty, then a new LDPRm is created from the current version of the LDPRv.
- If a Memento-Datetime header is provided as part of this POST request, then the newly created LDPRm must attempt to use it as the memento datetime
- If a LDPRm already exists with the same Memento-Datetime specified, then the LDPRm is not created and a '412 already exists' response is returned.
- Response from a successful creation should return a LDPRm headers, particularly the Memento-Datetime of the new LDPRm.
- Response must include a Location header referencing the URI of the newly created LDPRm.
Remove Support for Slug Header on POST to LDPCv
- Currently the modeshape fedora will request a "Slug" header be supplied to use as the label of the version. This should be taken out, to be replaced by the Memento-Datetime header, if that's present. The label should be a timestamp per the Memento DateTime Section of the Memento spec
Delete a LDPCv
- Deletes the LDPCv, which has the affect of also deleting all of the LDPRm's contained by it.
- The versioning interaction model is removed from the LDPRv (http://fedora.info/definitions/fcrepo#VersionedResource).
Delete a LDPRv
(this one might not actually be a ticket, since the behavior, though not totally correct, is in line with what we're targeting.)
DELETE of a LDPR is part of the fedora implementation currently, and will stay part of it. Per discussion on the fedora-tech list, linking the lifecycle of a LDPR and it's corresponding LDPRm's is okay. When the LDPRv is deleted, the mementos will also be deleted.
There is the concern about deleting LDPRs and LDPRm's that are referenced by other resources or versions of resources.
Implement application/link-format for TimeMaps
Requests to an LDPCv/TimeMap for a LDPRv must support a "application/link-format" response type, as shown in the example https://tools.ietf.org/html/rfc7089#page-37
- This response type is NOT required to include all statements in the LDPCv's graph, only those that are required by the link-format, outlined https://tools.ietf.org/html/rfc7089#page-36
- Including: URI of LDPRv for this timemap, all LDPRms in this LDPCv with their memento date times, timegate link, link to the LDPCv
HEAD / GET on LDPCv
- Must indicate TimeMap in the same way it indicates the Container interaction model of the resource via HTTP headers. See: https://fcrepo.github.io/fcrepo-specification/#general-3
- Must return Vary-Post and Vary-Put with value 'Memento-Datetime'.
Enable Versioning on a new LDPR
A PUT or POST request to create an object will make a resource versionable if it includes header Link: rel="type" with type of
A LDPR will be created as a LDPRv with the versioning type.
A LDPCv will be created
A LDPRm will be generated, contained by the LDPCv.
The newly created LDPCv:
- must not be a child of the LDPRv
- must be a LDPC ( https://fcrepo.github.io/fcrepo-specification/#LDPC )
- must be track its relationship to the LDPRv
- Note: it will be replacing the current "fcr:versions" path, which was previously used to access modeshape versions. Versioning will no longer be using built in modeshape tree snapshotting features features.
Enable Versioning on an Existing LDPR
Note: this is still under discussion since an empty PUT to an LDPR may not be valid.
A PUT request to an Existing LDPR will make a resource versionable if it includes header Link: rel="type" with type of
The versioning type will be added to the LDPR, making it a LDPRv.
A LDPCv will be created for the LDPRv
A LDPRm will be generated, contained by the LDPCv.
Restore a LDPRm
Discusssion of the details for this feature are still ongoing at https://github.com/fcrepo/fcrepo-specification/issues/217
- 4.1.1 Should the "timegate" link only be present when an object is versioned or should all LDPR that could be versioned provide this link?
- Yes, it should always be present
- This seems to imply that all resources are LDPRv's from the start
4.3.1 Why does each memento need a separate TimeMap to be created, rather than sharing one for all of the LDPRv and LDPRm of one LDPR?
- This was a misinterpretation. In the modeshape implementation, currently the timemap is the fcr:versions endpoint.
4.3.1 LDPCv must not be contained by the LDPRv does that mean that fcr:versions will no longer be a subpath of the LDPR?
- This only applies to ldp:contains, the uri is irrelevant
- 4.1.2 The Fcrepo spec doesn't mention it directly, but is there a conflict between the Memento "Content-Location" header and External File's "Content-Location"? Can they both appear in the same response?
- External File Content-Location header just appears on LDP-NR HEAD/GET requests, while Memento uses the header for responses from LDPRm and maybe LDPRv, both of which are LDP-RS's. So the headers should not both appear on the same response
- 4.3.1 How do you determine what serializations are available for TimeMaps? HEAD is not currently supported and is not in the Memento spec.
- GET response formats are not actually listed in any other requests, only for Post and Patch.
- However, it would likely be helpful to include info about HEAD and GET requests in the spec