Date

Call-in Information

Time: 10:00 am, Eastern Time (New York, GMT-04:00)

Attendees

(star)  Indicating note-taker

  1. Brian Lowe  
  2. Georgy Litvinov 
  3. Dragan Ivanovic 
  4. Huda Khan (star)

Agenda

  1. Strategy for merging the Dynamic API sprint branch
  2. Strategy for publishing April release 
    1. https://github.com/vivo-project/Vitro/pull/269  
    2. Completion of PRs reviewing - https://github.com/vivo-project/Vitro/pulls, https://github.com/vivo-project/VIVO/pulls
    3. Merging PRs 

Notes

  1. Strategy for merging the Dynamic API sprint branch
    1. Dragan: Not ready to be merged yet.  Do we keep it as a branch for next sprint?
      1. Not sure it would ruin functionality of Vitro/VIVO.  
      2. But not quite at point where it would be useful
      3. What was strategy earlier?  Merging branch or keep for later
      4. Brian: Sprint branch merged when complete/done
      5. Huda in chat: Pretty much what Brian said. Sprint retained past sprint itself, and then revisited/used when work continued later
        1. Georgy: Would allow for PRs/modifications to that branch
        2. Dragan: Seems like majority of work is addition of new files, so likelihood of major merge conflicts low if we keep the branch until later
    2. Georgy: Pros/cons for merging
      1. Saw some bugs and addressed them
      2. But most of functionality doesn’t modify the core features.  Shouldn’t be any merge conflicts
      3. Concern: Security. 
        1. Dragan: Two lines could be merged separately
      4. Concern: If we leave it not merged, could get point to merge conflicts later
  2. Strategy for publishing April release 
    1. Working on time based release.  First one in April.  Will need additional effort to make it possible to publish a new release in six months. 
    2. Will be topic in next few committer meetings around how to work on release
    3. Brian: Last release, people did some manual testing.  Around i18n functionality. 
      1. Testing of functionality not as problematic.  Publishing the release because changes of installer led to issues with artifacts
      2. Manual testing helped clarify the functionality itself was working
    4. Dragan: 
      1. Slack channel message to committers to test out the repository and make sure code is functional.  Make sure merging of pull requests into main is functional. 
      2. Then have release manager join with someone else from the group to work on documentation/learn about release process.  
      3. Then send message to slack again after to test out the release.  Not checked out from main but download the zipped file. 
      4. Brian: doesn’t seem like a bad idea to test out the release artifacts beforehand
    5. Started with pull request around release
      1. https://github.com/vivo-project/Vitro/pull/269  
        1. Dragan: Changing pom to war led to issues?
        2. Georgy: Not sure.
        3. Dragan: Bug that was encountered.  Ralph had said there had previously been an issue with publishing release, but problem might be in the code base. 
        4. Georgy: Vitro test requirement to have Vitro languages to parse the build on GitHub.  Haven’t had a chance to fix that build yet.  
          1. William suggested deploying Vitro languages in GitHub action and building it that way. 
          2. Dragan: William’s suggestion was to keep two different repositories (Vitro and Vitro languages) and then copy one into the other for building
          3. Georgy: Was an open question so had discussed two approaches
      2. Completion of PRs reviewing - https://github.com/vivo-project/Vitro/pulls, https://github.com/vivo-project/VIVO/pulls
        1. (Sorry missed a few PRs)
        2. 213 not urgent.  At point where Dynamic API is working, we may not even need it
        3. Vitro/VIVO languages: some contribution for Russian, also Serbian started, but not completed.  Not sure if ready for April.
          1. Georgy: Adding both cyrillic and latin?
          2. Dragan: Just cyrillic
        4. Dragan: Should we try in same release to publish Russian and Serbian languages?
      3. Merging PRs
    6. After Sprint, will try to review PRs again to see if something more could be reviewed
  3. Georgy: Is everything ok with DSpace and VIVO integration?  Not sure how it would work one way
    1. Dragan: First step, and based on budget, not realistic to do full integration

Draft notes on Google Drive

Actions

Previous actions 

  • No labels

All content on the LYRASIS Wiki is licensed under the CC BY (Attribution) license, unless otherwise noted.