Date

09 Mar 2023

Call-in Information

Time: 10:00 am, Eastern Time (New York, GMT-04:00)

• Join Zoom Meeting
  https://lyrasis.zoom.us/j/81398228834?pwd=SE0wdFN3NnFVbEhYVUhuM3BtQmVUQT09

  Meeting ID: 813 9822 8834
  Passcode: 728426

Attendees

 Indicating note-taker

1. Dragan Ivanovic  
2. William Welling
3. Brian Lowe 
4. Georgy Litvinov   

Agenda

1. When and how to align codebase with codestyle?
2. Sample data
   1. loading large sample data
3. Decoupling build and deployment
   1. Vitro?

Notes

1. Not yet ready to align codebase with codestyle, it might introduce a lot of merge conflicts in the community customizations/forks and branches (such as Dynamic api branch). Georgy suggested to be strict only with new files which should be aligned with codestyle. 
2. There is OutOfMemory issue with loading large sample data. openVIVO sample data might be loaded with a 4GB heap for tomcat, but can’t with 2GB. Splitting files into smaller ones is not resolving the issue. 
3. Practice of upgrading VIVO within the VIVO community is unclear, therefore it is hard to estimate how many cases https://github.com/vivo-project/Vitro/pull/370 is covering. Anyway, it is a step forward, it decouples the building and deployment process and we should adopt that as a solution after reviewing and testing. 
4. Dragan will prepare VIVO 1.14.0 release candidate number 2, after the testing of release candidate number 1. RC 2 will at least include fixes for some bugs in RC 1 already fixed by Georgy, plus it will include Kevin's contribution for adding a flag for disabling MapOfScience if that is needed for some VIVO adopters. 

Draft notes on Google Drive

Actions

Previous actions 

• Dragan Ivanovic to make consultation with the VIVO ontology group and Lyrasis system administrators about non-resolvable VIVO ontology links
• Committers to take part in the sprint PR review process
• Dragan Ivanovic to make a PR for fixing privileges for adding grant collaborators
• Brian Lowe to make a PR for fixing ordering of instances with multilingual properties
• Georgy Litvinov will investigate the problem of searching instances with multilingual properties
• Ralph O'Flinn to help with Preparing Documentation for Release by coping space VIVO 1.12.x Documentation to the space VIVO 1.13.x Documentation (or to grant Dragan Ivanovic permissions to do that)
• Dragan Ivanovic to work on documenting new features for VIVO 1.13.x Documentation
• Dragan Ivanovic to create the third one google form for reporting the testing results, that form should be used for testing new features introduced in VIVO 1.13.0
  • New Features: https://docs.google.com/forms/d/19FMslvvSzg_FK-Wmxg4t7EOP2UDft4FVdQvM4-2IO50/edit?usp=sharing
• Everyone to review https://docs.google.com/forms/d/13W2vynR6OmavoV2Px_kJ-k-dlQDv3ERWG0PnXX7ekQA/edit?usp=sharing and https://docs.google.com/forms/d/1dks3b3sJsmM7Q33bwHW_1iVem5VRjg3fqpx8UTFKIfI/edit?usp=sharing
  • and to review https://docs.google.com/forms/d/19FMslvvSzg_FK-Wmxg4t7EOP2UDft4FVdQvM4-2IO50/edit?usp=sharing
• Brian Lowe to work on removing spring dependencies (https://github.com/vivo-project/VIVO/issues/3686)
• Georgy Litvinov to work on PR for merging back a lost fix he noticed
• Everyone to review spreadsheet for defining requirements for JS and CSS framework selection - https://docs.google.com/spreadsheets/d/1p-86FdqQR2SpFIsK5Xa-k6Dgm5ORg6Lrc7eeOEetm8g/edit?usp=sharing

• Benjamin Gross to review https://github.com/vivo-project/Vitro/pull/251
• Dragan Ivanovic to review https://github.com/vivo-project/Vitro/pull/251
• Georgy Litvinov to fix the issue with GitHub action https://github.com/vivo-project/Vitro/pull/269
• Ralph O'Flinn to review https://github.com/vivo-project/Vitro/pull/269
• William Welling to review https://github.com/vivo-project/Vitro/pull/269
• Georgy Litvinov to update pom versions in https://github.com/vivo-project/VIVO-languages/pull/104 and https://github.com/vivo-project/Vitro-languages/pull/54
• Dragan Ivanovic to review and merge https://github.com/vivo-project/VIVO-languages/pull/104 and https://github.com/vivo-project/Vitro-languages/pull/54
• Georgy Litvinov to review https://github.com/vivo-project/VIVO/pull/3613
• Dragan Ivanovic to review https://github.com/vivo-project/Vitro/pull/240 
• Brian Lowe to review https://github.com/vivo-project/Vitro/pull/240
• Ralph O'Flinn to publish orcid-api-client 0.6.4 and update version of this library at https://github.com/vivo-project/VIVO/blob/main/api/pom.xml#L62

• Dragan Ivanovic to create announcement for the demo meeting and to spread it
• Dragan Ivanovic to reorganize code of https://github.com/vivo-project/Vitro/pull/287 and to get rid of enumerations for data types 
• Dragan Ivanovic to investigate organizational (management) aspects of DSpace community and to prepare discussion for the next meeting what might be adopted from there (GitHub actions, labels for issues, template for issue, template for PR)
• William Welling Georgy Litvinov to review sprint PRs (there should be three PRs)
• Brian Lowe to review N3Template operation PR (https://github.com/vivo-project/Vitro/pull/286)
• Georgy Litvinov to review/test https://github.com/vivo-project/orcid-api-client/pull/12
• Ralph O'Flinn to merge https://github.com/vivo-project/orcid-api-client/pull/12 and publish orcid-api-client 0.6.4
• Georgy Litvinov to complete https://github.com/vivo-project/Vitro/pull/251

• Ralph O'Flinn to merge https://github.com/vivo-project/VIVO/pull/3611, after that Georgy Litvinov will create a branch for the sprint and move the code from his fork to there
• Ralph O'Flinn to resolve missing i18n directory issue in VIVO 1.12.2 release
• Georgy Litvinov to work on specification for Dynamic API, Dragan Ivanovic to help Georgy on request
• Ralph O'Flinn to resolve missing i18n directory issue in VIVO 1.12.2 release
• Dragan Ivanovic to find some examples for citation of a GitHub repositories (https://github.com/vivo-project/VIVO/pull/247) 
• Georgy Litvinov to contact Tatiana Walther for reviewing https://github.com/vivo-project/VIVO-languages/pull/104 and https://github.com/vivo-project/Vitro-languages/pull/54
• Benjamin Gross to review https://github.com/vivo-project/VIVO/pull/250, https://github.com/vivo-project/Vitro/pull/251, and https://github.com/vivo-project/Vitro-languages/pull/56
• Brian Lowe to review https://github.com/vivo-project/Vitro/pull/213, https://github.com/vivo-project/Vitro-languages/pull/44, https://github.com/vivo-project/Vitro/pull/240, and https://github.com/vivo-project/VIVO-languages/pull/103
• William Welling to review https://github.com/vivo-project/Vitro/pull/241
• Huda Khan to review https://github.com/vivo-project/VIVO/pull/247