Date

14 Mar 2024

Call-in Information

Time: 11:00 am, Eastern Daylight Time, or 4:00 pm, Central European Time

• Join Zoom Meeting
  https://lyrasis.zoom.us/j/81398228834?pwd=SE0wdFN3NnFVbEhYVUhuM3BtQmVUQT09

  Meeting ID: 813 9822 8834
  Passcode: 728426

• calendar invitation - ics

Attendees

 Indicating note-taker

1. Dragan Ivanovic  
2. Georgy Litvinov   

Agenda

1. Readme file, contribution, join the community
• contributing.md 
• screenshots?
2. VIVO 1.14.1
• https://github.com/vivo-project/Vitro/pull/441
• https://github.com/vivo-project/Vitro/pull/448
3. VIVO 1.15.0
   • I forgot my password
   • https://github.com/vivo-project/Vitro/pull/421
   • https://github.com/vivo-project/VIVO/pull/3916
   • William’s issue with email links
   • Avoid lock on graph uri update in RdfServiceSparql
   • https://github.com/vivo-project/Vitro/pull/424
   • Might be postponed for VIVO 1.16.0?
   • robots.txt
   • https://github.com/vivo-project/VIVO/pull/3936
   • https://github.com/vivo-project/Vitro/pull/438
   • Replace qtip dependency
   • https://github.com/vivo-project/VIVO/pull/3937
   • https://github.com/vivo-project/Vitro/pull/439
   • Relation with responsive wilma theme?
   • Docker
   • https://github.com/vivo-project/VIVO/pull/3940
   • Tested by Ian Slatter, tested and reviewed by Ivan Mrsullja (linux), reviewed by Dragan
   • Freemarker dataGetter directive
   • https://github.com/vivo-project/Vitro/pull/440
   • Ready to be merged!
   • Role based search filters
   • https://github.com/vivo-project/Vitro/pull/442
   • Reviewers needed!
   • Collated faux object properties are not displayed in user profile
   • https://github.com/vivo-project/Vitro/pull/443
   • Is one reviewer enough?
   • Profile linking with Matching ID doesn't work
   • https://github.com/vivo-project/Vitro/pull/444,
   • The second reviewer needed
   • Suppress Display for object property in unrelated individuals hides property in related individual profiles
   • https://github.com/vivo-project/Vitro/pull/445
   • Is one reviewer enough?
   • Update jquery
   • https://github.com/vivo-project/Vitro/pull/449 
   • How to proceed? Which release? How to test?
   • Sanitized search query
   • https://github.com/vivo-project/Vitro/pull/447 
   • Reviewed by Dragan, hopefully Ben will be the second reviewer
• Open PR

Notes

Readme file, contribution, join the community

It would be nice to have screenshots in the explanation of the process of contribution. The question is where to preserve images (screenshots). Georgy suggested creating a documentation directory and inside that contribution subdirectory. Dragan will discuss with the rest of the team. 

VIVO 1.14.1

Georgy thinks we should resolve relocating once when it is an issue, at the moment it works, and we don’t know in which direction log4j will go in the future. This can simplify the process of publishing a patch for VIVO 1.14, because we have just to cherry pick existing commits from the main branch. Also, Dragan will cherry pick commit (https://github.com/vivo-project/Vitro/pull/441) and prepare VIVO 1.14.1

VIVO 1.15.0

I forgot my password

Georgy and Dragan can’t reproduce William's issue with email links. It might be discussed once again with William. 

Georgy has additional suggestions for Ivan for improvement of the PR. It will be added in the PR discussion track. 

Avoid lock on graph uri update in RdfServiceSparql

Might be postponed for VIVO 1.16.0

Docker

https://github.com/vivo-project/VIVO/pull/3940

Tested by Ian Slatter, tested and reviewed by Ivan Mrsullja (linux), reviewed by Dragan. Ready to be merged if no objection from the rest of the team. 

Freemarker dataGetter directive

https://github.com/vivo-project/Vitro/pull/440

Ready to be merged if no objection from the rest of the team

Role based search filters

https://github.com/vivo-project/Vitro/pull/442

Reviewers needed! We need someone to test this feature. 

Profile linking with Matching ID doesn't work

https://github.com/vivo-project/Vitro/pull/444,

The second reviewer is needed (Java code review, sparql, ontology, testing). 

Collated faux object properties are not displayed in user profile

https://github.com/vivo-project/Vitro/pull/443

This PR might be classified as a small PR which requires only one reviewer. 

Suppress Display for object property in unrelated individuals hides property in related individual profiles

https://github.com/vivo-project/Vitro/pull/445

This PR might be classified as a small PR which requires only one reviewer. 

Update jquery

https://github.com/vivo-project/Vitro/pull/449 

How to proceed? Which release? How to test?

Georgy suggested trying to decouple this PR in a couple of PRs, the first one is just adding a new jquery library, the others are part by part update of existing code to the new library. 

Sanitized search query

https://github.com/vivo-project/Vitro/pull/447 

Reviewed by Dragan, hopefully Ben will be the second reviewer.

Draft notes on Google Drive

Actions

• Dragan Ivanovic to prepare VIVO 1.14.1 release candidate
• Dragan Ivanovic to post a message in the VIVO committers channel about questions from this meeting

Previous actions 

• Dragan Ivanovic to align Pull request template with Brian's suggestions
• Dragan Ivanovic to draft CONTRIBUTING.md file
• Dragan Ivanovic to create a new ticket for log4j vulnerability mitigation and to link to https://github.com/vivo-project/Vitro/pull/441
• William Welling to review https://github.com/vivo-project/Vitro/pull/421 and https://github.com/vivo-project/VIVO/pull/3916
• Georgy Litvinov to draft updates for https://github.com/vivo-project/VIVO/wiki/Development-Processes#process-for-reviewing-contribution 
• Dragan Ivanovic to draft updates for PR template
• Dragan Ivanovic to contact Arif regarding opening a ticket (feature request) for home page statistics
• Dragan Ivanovic will inform Ivan about decisions for I forgot my password PR
• Georgy Litvinov to review https://github.com/vivo-project/Vitro/pull/427
• Brian Lowe to review https://github.com/vivo-project/Vitro/pull/424
• Georgy Litvinov to improve https://github.com/vivo-project/Vitro/pull/433 (UI options for defining policies)
• Dragan Ivanovic to work on wiki documentation
• Dragan Ivanovic to contact Ralph O'Flinn about https://github.com/vivo-community/create-wsl2-vivo-dev-env
• Dragan Ivanovic to communicate with the Lyrasis team about adding commenting permissions to anonymous wiki users
• Ivan Mrsulja to implement suggested improvements into https://github.com/vivo-project/Vitro/pull/427
• Georgy Litvinov to improve https://github.com/vivo-project/Vitro/pull/390 in accordance with Miloš Popović review
• Dragan Ivanovic to review https://github.com/vivo-project/Vitro/pull/431
• Dragan Ivanovic to review https://github.com/vivo-project/Vitro/pull/432 
• Georgy Litvinov to complete https://github.com/vivo-project/Vitro/pull/433
• Dragan Ivanovic to discuss with Milos Popovic about usage of JQuery in the nemo theme
• Georgy Litvinov to provide Dragan the information about volume size needed for mirroring GitHub into GitLab
• Dragan Ivanovic and Georgy Litvinov to complete merging the ABAC PRs
• Dragan Ivanovic to review extended search PR and Avoid lock on graph uri update in RdfServiceSparql PR
• William Welling will continue working on vivo-solr upgrade branch
• Ivan Mrsulja will consider adding a configuration flag for turning on/off the "I forgot my password" feature

• Dragan Ivanovic to talk with Ivan Mrsulja about improvements of https://github.com/vivo-project/Vitro/pull/421 in accordance with committers' discussion
• Dragan Ivanovic to inform Miloš Popović that bootstrap javascript functions are used in the extended search
• Georgy Litvinov to continue working on ABAC PR and inform us back when it is completed and ready for testing and reviewing
• Dragan Ivanovic to open a GitHub ticket for Mac M1 chip issue
• Dragan Ivanovic to create a PR for upgrading slf4j-log4j12 - https://github.com/vivo-project/Vitro/blob/main/dependencies/pom.xml#L215
• Dragan Ivanovic will open a GitHub ticket for  Log4j vulnerability
  • https://github.com/vivo-project/VIVO/issues/3913
• Dragan Ivanovic will open a GitHub ticket for  Removing trash icon for some specific types
  • https://github.com/vivo-project/VIVO/issues/3914

• Dragan Ivanovic will further investigate mirroring GitHub repositories to a self-managed instance of a GitLab platform
• Georgy Litvinov will upgrade https://github.com/vivo-project/Vitro/pull/398
•  Dragan Ivanovic should investigate https://github.com/marketplace?category=backup-utilities
• Dragan Ivanovic to prepare VIVO 1.14.0 release
• Dragan Ivanovic to prepare release candidate 4
• Georgy Litvinov to align https://vivo.tib.eu/vivorc/ with release candidate 4
• Dragan Ivanovic to respond to slack messages
• Dragan Ivanovic will try to collect wiki pages where strategy, vision and roadmap for development of VIVO were discussed in the past
• Georgy Litvinov will try to address the issue https://github.com/vivo-project/VIVO/issues/3871
• Dragan Ivanovic will ask Michael to open a GitHub ticket for the issue about UF performance during login (https://vivo-project.slack.com/archives/C8RL9L98A/p1684174222986709), Brian Lowe and others can continue discussion about this issue once a ticket is open
• Dragan Ivanovic will ask Rodrigo to open a GitHub ticket for the issue about custom theme and VIVO Docker (https://vivo-project.slack.com/archives/C8RL9L98A/p1684962021101889), William Welling  and others can continue discussion about this issue once a ticket is open
• Brian Lowe to open a GitHub issue for index page exception
  • https://github.com/vivo-project/VIVO/issues/3867
  • add sample (minimal RDF to reproduce the issue)
• Miloš Popović or Ivan Mrsulja to review (https://github.com/vivo-project/VIVO/issues/3862)
  • https://github.com/vivo-project/VIVO/pull/3863
  • https://github.com/vivo-project/Vitro/pull/386
• Georgy Litvinov to review (https://github.com/vivo-project/VIVO/issues/3847)
  • https://github.com/vivo-project/Vitro/pull/383
• Review (https://github.com/vivo-project/VIVO/issues/3865)
  • https://github.com/vivo-project/VIVO/pull/3866
• Review (https://github.com/vivo-project/VIVO/issues/3864)
  • https://github.com/vivo-project/Vitro/pull/387
• Review (https://github.com/vivo-project/VIVO/issues/3858)
  • https://github.com/vivo-project/Vitro/pull/385
• Review (https://github.com/vivo-project/VIVO/issues/3859)
  • https://github.com/vivo-project/Vitro/pull/384
• Review (https://github.com/vivo-project/VIVO/issues/3855)
  • https://github.com/vivo-project/VIVO/pull/3861
• Review (https://github.com/vivo-project/VIVO/security/dependabot/3)
  • https://github.com/vivo-project/VIVO/pull/3853

• Brian Lowe and William Welling to review https://github.com/vivo-project/VIVO/pull/3853
• William Welling to review https://github.com/vivo-project/VIVO/pull/3861
• All to think how to organize scripts for VIVO (at the moment for dump and restore) - https://github.com/vivo-project/Vitro/pull/380

• Dragan Ivanovic to make consultation with the VIVO ontology group and Lyrasis system administrators about non-resolvable VIVO ontology links
• Committers to take part in the sprint PR review process
• Dragan Ivanovic to make a PR for fixing privileges for adding grant collaborators
• Brian Lowe to make a PR for fixing ordering of instances with multilingual properties
• Georgy Litvinov will investigate the problem of searching instances with multilingual properties
• Ralph O'Flinn to help with Preparing Documentation for Release by coping space VIVO 1.12.x Documentation to the space VIVO 1.13.x Documentation (or to grant Dragan Ivanovic permissions to do that)
• Dragan Ivanovic to work on documenting new features for VIVO 1.13.x Documentation
• Dragan Ivanovic to create the third one google form for reporting the testing results, that form should be used for testing new features introduced in VIVO 1.13.0
  • New Features: https://docs.google.com/forms/d/19FMslvvSzg_FK-Wmxg4t7EOP2UDft4FVdQvM4-2IO50/edit?usp=sharing
• Everyone to review https://docs.google.com/forms/d/13W2vynR6OmavoV2Px_kJ-k-dlQDv3ERWG0PnXX7ekQA/edit?usp=sharing and https://docs.google.com/forms/d/1dks3b3sJsmM7Q33bwHW_1iVem5VRjg3fqpx8UTFKIfI/edit?usp=sharing
  • and to review https://docs.google.com/forms/d/19FMslvvSzg_FK-Wmxg4t7EOP2UDft4FVdQvM4-2IO50/edit?usp=sharing
• Brian Lowe to work on removing spring dependencies (https://github.com/vivo-project/VIVO/issues/3686)
• Georgy Litvinov to work on PR for merging back a lost fix he noticed
• Everyone to review spreadsheet for defining requirements for JS and CSS framework selection - https://docs.google.com/spreadsheets/d/1p-86FdqQR2SpFIsK5Xa-k6Dgm5ORg6Lrc7eeOEetm8g/edit?usp=sharing

• Benjamin Gross to review https://github.com/vivo-project/Vitro/pull/251
• Dragan Ivanovic to review https://github.com/vivo-project/Vitro/pull/251
• Georgy Litvinov to fix the issue with GitHub action https://github.com/vivo-project/Vitro/pull/269
• Ralph O'Flinn to review https://github.com/vivo-project/Vitro/pull/269
• William Welling to review https://github.com/vivo-project/Vitro/pull/269
• Georgy Litvinov to update pom versions in https://github.com/vivo-project/VIVO-languages/pull/104 and https://github.com/vivo-project/Vitro-languages/pull/54
• Dragan Ivanovic to review and merge https://github.com/vivo-project/VIVO-languages/pull/104 and https://github.com/vivo-project/Vitro-languages/pull/54
• Georgy Litvinov to review https://github.com/vivo-project/VIVO/pull/3613
• Dragan Ivanovic to review https://github.com/vivo-project/Vitro/pull/240 
• Brian Lowe to review https://github.com/vivo-project/Vitro/pull/240
• Ralph O'Flinn to publish orcid-api-client 0.6.4 and update version of this library at https://github.com/vivo-project/VIVO/blob/main/api/pom.xml#L62

• Dragan Ivanovic to create announcement for the demo meeting and to spread it
• Dragan Ivanovic to reorganize code of https://github.com/vivo-project/Vitro/pull/287 and to get rid of enumerations for data types 
• Dragan Ivanovic to investigate organizational (management) aspects of DSpace community and to prepare discussion for the next meeting what might be adopted from there (GitHub actions, labels for issues, template for issue, template for PR)
• William Welling Georgy Litvinov to review sprint PRs (there should be three PRs)
• Brian Lowe to review N3Template operation PR (https://github.com/vivo-project/Vitro/pull/286)
• Georgy Litvinov to review/test https://github.com/vivo-project/orcid-api-client/pull/12
• Ralph O'Flinn to merge https://github.com/vivo-project/orcid-api-client/pull/12 and publish orcid-api-client 0.6.4
• Georgy Litvinov to complete https://github.com/vivo-project/Vitro/pull/251

• Ralph O'Flinn to merge https://github.com/vivo-project/VIVO/pull/3611, after that Georgy Litvinov will create a branch for the sprint and move the code from his fork to there
• Ralph O'Flinn to resolve missing i18n directory issue in VIVO 1.12.2 release
• Georgy Litvinov to work on specification for Dynamic API, Dragan Ivanovic to help Georgy on request
• Ralph O'Flinn to resolve missing i18n directory issue in VIVO 1.12.2 release
• Dragan Ivanovic to find some examples for citation of a GitHub repositories (https://github.com/vivo-project/VIVO/pull/247) 
• Georgy Litvinov to contact Tatiana Walther for reviewing https://github.com/vivo-project/VIVO-languages/pull/104 and https://github.com/vivo-project/Vitro-languages/pull/54
• Benjamin Gross to review https://github.com/vivo-project/VIVO/pull/250, https://github.com/vivo-project/Vitro/pull/251, and https://github.com/vivo-project/Vitro-languages/pull/56
• Brian Lowe to review https://github.com/vivo-project/Vitro/pull/213, https://github.com/vivo-project/Vitro-languages/pull/44, https://github.com/vivo-project/Vitro/pull/240, and https://github.com/vivo-project/VIVO-languages/pull/103
• William Welling to review https://github.com/vivo-project/Vitro/pull/241
• Huda Khan to review https://github.com/vivo-project/VIVO/pull/247