Date

25 Aug 2022

Call-in Information

Time: 10:00 am, Eastern Time (New York, GMT-04:00)

• Join Zoom Meeting
  https://lyrasis.zoom.us/j/81398228834?pwd=SE0wdFN3NnFVbEhYVUhuM3BtQmVUQT09

  Meeting ID: 813 9822 8834
  Passcode: 728426

Attendees

 Indicating note-taker

1. Georgy Litvinov 
2. Dragan Ivanovic
3. Brian Lowe  
4. William Welling 
5. Benjamin Gross

Agenda

1. Publishing the VIVO 1.13.0 release 
   1. Publishing a release candidate 3
      1. Done
   2. Testing the release candidate
      1. for release candidate only new fixes should be tested 
         1. https://github.com/vivo-project/Vitro/pull/321
         2. https://github.com/vivo-project/Vitro/pull/322/files
         3. https://github.com/vivo-project/VIVO/pull/3734
      2. Wiki page - Release Testing - 1.13.0 
         1. deployment of VIVO and Vitro
            1. mvn clean install
         2. GoogleForms
            1. Standard tests - https://forms.gle/cqk3oK7UmJpDWGYt8
            2. Special focus on the new features - https://docs.google.com/forms/d/19FMslvvSzg_FK-Wmxg4t7EOP2UDft4FVdQvM4-2IO50/edit?usp=sharing
            3. Advanced tests - https://forms.gle/ZZLeVdBuDFMEMTGM
         3. https://vivo.tib.eu/vivo113rc
   3. VIVO 1.13.0 Technical Documentation
      1. Wiki space - VIVO 1.13.x Documentation
      2. Adding of technical documentation for:
         1. Deletion of individuals 
            1. done
         2. Installing VIVO
      3.  Release Notes
         1. updated
   4. Publishing VIVO 1.13.0 
2. VIVO-solr
   1. https://github.com/vivo-project/vivo-solr/pull/6
3. Reviewing old PRs (<2021)
   1. https://github.com/vivo-project/VIVO-languages/pulls (4)
   2. https://github.com/vivo-project/Vitro/pulls (10)
   3. https://github.com/vivo-project/VIVO/pulls (10)
4. Improvement of GitHub code management 
   1. bug report template
      1. VIVO
      2. DSpace
   2. feature request template
      1. VIVO
      2. DSpace
   3. task definition template
      1. for upgrading dependencies, mitigation of security vulnerability
      2. is that a good practice?
         1. https://github.com/golang/go/issues/new/choose
         2. https://github.com/microsoft/repo-templates/blob/main/shared/SECURITY.md
         3. https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/configuring-issue-templates-for-your-repository
         4. https://github.com/DSpace/DSpace/issues/new/choose
   4. pull request template
      1. VIVO
      2. DSpace
   5. GitHub actions
      1. list of actions
         1. VIVO
         2. DSpace
      2. build.yml
         1. VIVO
         2. DSpace
            1. codecov
               1. alternatives - codeclimate, etc.
            2. separation of unit and integration tests
      3. docker.yml
         1. VIVO
         2. DSpace
      4. label merge conflicts yml
         1. DSpace
      5. adding new issue to project board yml
         1. DSpace
            1. Issues should be added for instance in a dedicated VIVO backlogs project board for triage (similarly as DSpace Backlogs - https://github.com/orgs/DSpace/projects)
      6. codeQL analysis
         1. VIVO
         2. continues security analysis - LGTM
            1. https://lgtm.com/projects/g/vivo-project/Vitro/?mode=list
   6. labels
      1. list of labels
         1. VIVO
         2. DSpace
      2. assignment of labels to issues
         1. VIVO
         2. DSpace

Notes

Draft notes on Google Drive

1. PR - Vitro 326 and VIVO 3745
1. One line change fixing email example settings
2. Publishing the VIVO 1.13.0 release 
1. Publishing a release candidate 3 for VIVO
1. Done. RC for VIVO languages is still on #1, RC-2 for Vitro.
2. Testing the release candidate
1. for release candidate only new fixes should be tested 
1. https://github.com/vivo-project/Vitro/pull/321 (Issue/vivo 3606 : add language-specific sorting and label fields to search index)
2. https://github.com/vivo-project/Vitro/pull/322/files (fix: use public description in data property template model)
3. https://github.com/vivo-project/VIVO/pull/3734 (Privilages for editing grant contributors)
4. Another PR https://github.com/vivo-project/Vitro/pull/325 to fix property type for use with reconciliation services 
3. Dragan considering rolling these changes into RC-3. Not exactly right.. Might create RC-4.
4. Question on OpenRefine from Brian
1. Should this be on by default?! See example.runtime.properties: https://github.com/vivo-project/VIVO/blob/main/home/src/main/resources/config/example.runtime.properties#L414
2. Big question… does this service honor visibility settings?!
3. Easily solution is to comment out the defaultTypeList setting
4. Perhaps add note to upgrade notes that encourages users to review enabled services in runtime.properties 
5. VIVO 1.13.0 Technical Documentation
1. Wiki space - VIVO 1.13.x Documentation
2. Adding of technical documentation for:
1. Deletion of individuals 
1. done
2. Installing VIVO
3.  Release Notes
1. Updated by Dragan
6. Publishing VIVO 1.13.0 
3. VIVO-solr
1. https://github.com/vivo-project/vivo-solr/pull/6
2. Brian suggested rolling vivo-solr back into main VIVO project
3. Georgy disagrees. It doesn’t interact with VIVO app at all. 
4. Also Elasticsearch is an option
5. Don’t want to delay new VIVO release with this discussion
6. What was the original purpose of separating this out? Similar to VIVO and Vitro languages? Makes it much more difficult to work with source code.
7. One argument for separate repo, encourages contributions without ‘scary’ Vitro code
8. If we combine, won’t be for this release
4. Reviewing old PRs (<2021)
1. https://github.com/vivo-project/VIVO-languages/pulls (4)
2. https://github.com/vivo-project/Vitro/pulls (10)
3. https://github.com/vivo-project/VIVO/pulls (10)
4. Proposal - if no response to requests for changes, close a pull request after a certain number of months (5 or 6?)
5. How do we review in general language-based PRs when we don’t speak the language? In some cases we just have to trust the PR submitter. 
6. Brian agrees with Benjamin that closing very old PRs is a good idea… they can always be reopened.

Request from Dragan: review and merge the new PRs ASAP so we can push out a new RC!

Actions

Previous actions 

• Dragan Ivanovic to make a PR for fixing privileges for adding grant collaborators
• Brian Lowe to make a PR for fixing ordering of instances with multilingual properties
• Georgy Litvinov will investigate the problem of searching instances with multilingual properties
• Ralph O'Flinn to help with Preparing Documentation for Release by coping space VIVO 1.12.x Documentation to the space VIVO 1.13.x Documentation (or to grant Dragan Ivanovic permissions to do that)
• Dragan Ivanovic to work on documenting new features for VIVO 1.13.x Documentation
• Dragan Ivanovic to create the third one google form for reporting the testing results, that form should be used for testing new features introduced in VIVO 1.13.0
  • New Features: https://docs.google.com/forms/d/19FMslvvSzg_FK-Wmxg4t7EOP2UDft4FVdQvM4-2IO50/edit?usp=sharing
• Everyone to review https://docs.google.com/forms/d/13W2vynR6OmavoV2Px_kJ-k-dlQDv3ERWG0PnXX7ekQA/edit?usp=sharing and https://docs.google.com/forms/d/1dks3b3sJsmM7Q33bwHW_1iVem5VRjg3fqpx8UTFKIfI/edit?usp=sharing
  • and to review https://docs.google.com/forms/d/19FMslvvSzg_FK-Wmxg4t7EOP2UDft4FVdQvM4-2IO50/edit?usp=sharing
• Brian Lowe to work on removing spring dependencies (https://github.com/vivo-project/VIVO/issues/3686)
• Georgy Litvinov to work on PR for merging back a lost fix he noticed
• Everyone to review spreadsheet for defining requirements for JS and CSS framework selection - https://docs.google.com/spreadsheets/d/1p-86FdqQR2SpFIsK5Xa-k6Dgm5ORg6Lrc7eeOEetm8g/edit?usp=sharing

• Benjamin Gross to review https://github.com/vivo-project/Vitro/pull/251
• Dragan Ivanovic to review https://github.com/vivo-project/Vitro/pull/251
• Georgy Litvinov to fix the issue with GitHub action https://github.com/vivo-project/Vitro/pull/269
• Ralph O'Flinn to review https://github.com/vivo-project/Vitro/pull/269
• William Welling to review https://github.com/vivo-project/Vitro/pull/269
• Georgy Litvinov to update pom versions in https://github.com/vivo-project/VIVO-languages/pull/104 and https://github.com/vivo-project/Vitro-languages/pull/54
• Dragan Ivanovic to review and merge https://github.com/vivo-project/VIVO-languages/pull/104 and https://github.com/vivo-project/Vitro-languages/pull/54
• Georgy Litvinov to review https://github.com/vivo-project/VIVO/pull/3613
• Dragan Ivanovic to review https://github.com/vivo-project/Vitro/pull/240 
• Brian Lowe to review https://github.com/vivo-project/Vitro/pull/240
• Ralph O'Flinn to publish orcid-api-client 0.6.4 and update version of this library at https://github.com/vivo-project/VIVO/blob/main/api/pom.xml#L62

• Dragan Ivanovic to create announcement for the demo meeting and to spread it
• Dragan Ivanovic to reorganize code of https://github.com/vivo-project/Vitro/pull/287 and to get rid of enumerations for data types 
• Dragan Ivanovic to investigate organizational (management) aspects of DSpace community and to prepare discussion for the next meeting what might be adopted from there (GitHub actions, labels for issues, template for issue, template for PR)
• William Welling Georgy Litvinov to review sprint PRs (there should be three PRs)
• Brian Lowe to review N3Template operation PR (https://github.com/vivo-project/Vitro/pull/286)
• Georgy Litvinov to review/test https://github.com/vivo-project/orcid-api-client/pull/12
• Ralph O'Flinn to merge https://github.com/vivo-project/orcid-api-client/pull/12 and publish orcid-api-client 0.6.4
• Georgy Litvinov to complete https://github.com/vivo-project/Vitro/pull/251

• Ralph O'Flinn to merge https://github.com/vivo-project/VIVO/pull/3611, after that Georgy Litvinov will create a branch for the sprint and move the code from his fork to there
• Ralph O'Flinn to resolve missing i18n directory issue in VIVO 1.12.2 release
• Georgy Litvinov to work on specification for Dynamic API, Dragan Ivanovic to help Georgy on request
• Ralph O'Flinn to resolve missing i18n directory issue in VIVO 1.12.2 release
• Dragan Ivanovic to find some examples for citation of a GitHub repositories (https://github.com/vivo-project/VIVO/pull/247) 
• Georgy Litvinov to contact Tatiana Walther for reviewing https://github.com/vivo-project/VIVO-languages/pull/104 and https://github.com/vivo-project/Vitro-languages/pull/54
• Benjamin Gross to review https://github.com/vivo-project/VIVO/pull/250, https://github.com/vivo-project/Vitro/pull/251, and https://github.com/vivo-project/Vitro-languages/pull/56
• Brian Lowe to review https://github.com/vivo-project/Vitro/pull/213, https://github.com/vivo-project/Vitro-languages/pull/44, https://github.com/vivo-project/Vitro/pull/240, and https://github.com/vivo-project/VIVO-languages/pull/103
• William Welling to review https://github.com/vivo-project/Vitro/pull/241
• Huda Khan to review https://github.com/vivo-project/VIVO/pull/247