Date
Call-in Information
Time: 11:00 am, Eastern Daylight Time, or 4:00 pm, Central European Time
Join Zoom Meeting
https://lyrasis.zoom.us/j/81398228834?pwd=SE0wdFN3NnFVbEhYVUhuM3BtQmVUQT09Meeting ID: 813 9822 8834
Passcode: 728426- calendar invitation - ics
Attendees
Indicating note-taker
Agenda
- VIVO 1.15.0
- To be reverted
- Active
- I forgot my password
- Role based search filters
- https://github.com/vivo-project/Vitro/pull/442
- Reviewers needed!
- Profile linking with Matching ID doesn't work
- https://github.com/vivo-project/VIVO/pull/3947
- https://github.com/vivo-project/Vitro/pull/444
- The second reviewer needed
- SPARQL authorization cache
- https://github.com/vivo-project/Vitro/pull/450
- The second reviewer needed?
- Object property statement can't be hidden from display without hiding all property statements in individual profile
- https://github.com/vivo-project/Vitro/pull/451
- The second reviewer needed?
- Menu pages can't be modified
- Date time interval doesn't allow end date to be equal start date
- https://github.com/vivo-project/Vitro/pull/453
- Ready to be merged
- New
- Research areas
- Readme file, contribution, join the community
- contributing.md
- screenshots?
Notes
Responsive wilma theme
Team decided to revert PRs related to making the Wilma theme responsive, to create a new one PR which will fix some meanwhile noticed issues with this theme.
The PR https://github.com/vivo-project/VIVO/pull/3932 was reverted by using a GitHub option.
Due to some conflict, PRs https://github.com/vivo-project/VIVO/pull/3909, https://github.com/vivo-project/Vitro/pull/429 could not be automatically reverted by using GitHub. Georgy will try to make revert PRs for those. Dragan will review and merge those PRs created by Georgy. Dragan will inform Milos (the author of PRs) to cherry pick commits and create new PRs (one for VIVO and one for Vitro). The next steps will be to test it and to fix issues.
I forgot my password
https://github.com/vivo-project/VIVO/pull/3916
https://github.com/vivo-project/Vitro/pull/421
Georgy and William will review this PRs pair. Ivan reported that some i18n messages have been changed, Dragan suggested validating those messages by native speakers after reviewing PRs by Georgy and William.
Role based search filters
https://github.com/vivo-project/Vitro/pull/442
The second reviewer for this PR will be William. In the case, William can’t find time to review this in the next couple of weeks, an alternative reviewer might be Ivan.
Profile linking with Matching ID doesn't work
https://github.com/vivo-project/VIVO/pull/3947
https://github.com/vivo-project/Vitro/pull/444
Dragan will review this again. However, a second reviewer is needed for reviewing the code of this PR for sure.
SPARQL authorization cache
https://github.com/vivo-project/Vitro/pull/450
Dragan thinks the second reviewer for this PR is not needed and will suggest merging of this PR with one reviewer in the #committers channel. If there is no objection, it might be merged (NOTE 1: only the last commit is new in this PR, which changed one java file and adding a JUnit test
NOTE 2: this PR has to be merged after merging https://github.com/vivo-project/Vitro/pull/444)
Object property statement can't be hidden from display without hiding all property statements in individual profile
https://github.com/vivo-project/Vitro/pull/451
Dragan thinks the second reviewer for this PR is not needed and will suggest merging of this PR with one reviewer in the #committers channel. If there is no objection, it might be merged.
Menu pages can't be modified
https://github.com/vivo-project/Vitro/pull/452
Dragan tested this PR, after reviewing the code he will report back to Georgy (author of the PR)
Date time interval doesn't allow end date to be equal start date
https://github.com/vivo-project/Vitro/pull/453
Dragan thinks the second reviewer for this PR is not needed and will suggest merging of this PR with one reviewer in the #committers channel. If there is no objection, it might be merged.
TinyMCE
https://github.com/vivo-project/Vitro/pull/454
Dragan will test and review the code.
JQuery
https://github.com/vivo-project/VIVO/pull/3955
https://github.com/vivo-project/Vitro/pull/449
This PR is complicated for testing and reviewing. Benjamin explained the process he applied in the implementation of this PR. It is already at a development server for one VIVO instance, meaning it is at least partially tested. The issue is whether it is working for all themes. Georgy suggested to split PR into:
- A PR which is adding a newJQuery directory with new library (and keeping old jquery library). This PR can be safely and easily merged in the main branch
- A separated PRs for each theme
At the end, we can in one minor VIVO release announce that usage of old jquery is deprecated, and in the next minor VIVO release we can remove old jquery.
Benjamin switched PR to draft, and he will wait to inform him once responsive wilma theme PR is merged to start making PRs.
Research areas
Georgy explained there is the option in Researchers profile pages (or Work pages) to manage research areas, and there is the option to create new or select an existing concept. Dragan will reply to the email with this explanation.
Actions
- Georgy Litvinov to create revert PRs for wilma responsive PRs
- Dragan Ivanovic to review (and merge if it ok) revert PRs
- William Welling to review assigned PRs
- Dragan Ivanovic to respond on email in accordance with discussion at this meeting
- Benjamin Gross to split JQuery PR into smaller one (one per theme) once when "Wilma responsive theme" task is completed and merged
- Dragan Ivanovic to discuss merging of simple PRs with only one reviewer in the #committers slack channel
Previous actions
- Dragan Ivanovic to prepare VIVO 1.14.1 release candidate
- Dragan Ivanovic to post a message in the VIVO committers channel about questions from this meeting
- Dragan Ivanovic to align Pull request template with Brian's suggestions
- Dragan Ivanovic to draft CONTRIBUTING.md file
- Dragan Ivanovic to create a new ticket for log4j vulnerability mitigation and to link to https://github.com/vivo-project/Vitro/pull/441
- William Welling to review https://github.com/vivo-project/Vitro/pull/421 and https://github.com/vivo-project/VIVO/pull/3916
- Georgy Litvinov to draft updates for https://github.com/vivo-project/VIVO/wiki/Development-Processes#process-for-reviewing-contribution
- Dragan Ivanovic to draft updates for PR template
- Dragan Ivanovic to contact Arif regarding opening a ticket (feature request) for home page statistics
- Dragan Ivanovic will inform Ivan about decisions for I forgot my password PR
- Georgy Litvinov to review https://github.com/vivo-project/Vitro/pull/427
- Brian Lowe to review https://github.com/vivo-project/Vitro/pull/424
- Georgy Litvinov to improve https://github.com/vivo-project/Vitro/pull/433 (UI options for defining policies)
- Dragan Ivanovic to work on wiki documentation
- Dragan Ivanovic to contact Ralph O'Flinn about https://github.com/vivo-community/create-wsl2-vivo-dev-env
- Dragan Ivanovic to communicate with the Lyrasis team about adding commenting permissions to anonymous wiki users
- Ivan Mrsulja to implement suggested improvements into https://github.com/vivo-project/Vitro/pull/427
- Georgy Litvinov to improve https://github.com/vivo-project/Vitro/pull/390 in accordance with Miloš Popović review
- Dragan Ivanovic to review https://github.com/vivo-project/Vitro/pull/431
- Dragan Ivanovic to review https://github.com/vivo-project/Vitro/pull/432
- Georgy Litvinov to complete https://github.com/vivo-project/Vitro/pull/433
- Dragan Ivanovic to discuss with Milos Popovic about usage of JQuery in the nemo theme
- Georgy Litvinov to provide Dragan the information about volume size needed for mirroring GitHub into GitLab
- Dragan Ivanovic and Georgy Litvinov to complete merging the ABAC PRs
- Dragan Ivanovic to review extended search PR and Avoid lock on graph uri update in RdfServiceSparql PR
- William Welling will continue working on vivo-solr upgrade branch
- Ivan Mrsulja will consider adding a configuration flag for turning on/off the "I forgot my password" feature
- Dragan Ivanovic to talk with Ivan Mrsulja about improvements of https://github.com/vivo-project/Vitro/pull/421 in accordance with committers' discussion
- Dragan Ivanovic to inform Miloš Popović that bootstrap javascript functions are used in the extended search
- Georgy Litvinov to continue working on ABAC PR and inform us back when it is completed and ready for testing and reviewing
- Dragan Ivanovic to open a GitHub ticket for Mac M1 chip issue
- Dragan Ivanovic to create a PR for upgrading slf4j-log4j12 - https://github.com/vivo-project/Vitro/blob/main/dependencies/pom.xml#L215
- Dragan Ivanovic will open a GitHub ticket for Log4j vulnerability
- Dragan Ivanovic will open a GitHub ticket for Removing trash icon for some specific types
- Dragan Ivanovic will further investigate mirroring GitHub repositories to a self-managed instance of a GitLab platform
- Georgy Litvinov will upgrade https://github.com/vivo-project/Vitro/pull/398
- Dragan Ivanovic should investigate https://github.com/marketplace?category=backup-utilities
- Dragan Ivanovic to prepare VIVO 1.14.0 release
- Dragan Ivanovic to prepare release candidate 4
- Georgy Litvinov to align https://vivo.tib.eu/vivorc/ with release candidate 4
- Dragan Ivanovic to respond to slack messages
- Dragan Ivanovic will try to collect wiki pages where strategy, vision and roadmap for development of VIVO were discussed in the past
- Georgy Litvinov will try to address the issue https://github.com/vivo-project/VIVO/issues/3871
- Dragan Ivanovic will ask Michael to open a GitHub ticket for the issue about UF performance during login (https://vivo-project.slack.com/archives/C8RL9L98A/p1684174222986709), Brian Lowe and others can continue discussion about this issue once a ticket is open
- Dragan Ivanovic will ask Rodrigo to open a GitHub ticket for the issue about custom theme and VIVO Docker (https://vivo-project.slack.com/archives/C8RL9L98A/p1684962021101889), William Welling and others can continue discussion about this issue once a ticket is open
- Brian Lowe to open a GitHub issue for index page exception
- https://github.com/vivo-project/VIVO/issues/3867
- add sample (minimal RDF to reproduce the issue)
- Miloš Popović or Ivan Mrsulja to review (https://github.com/vivo-project/VIVO/issues/3862)
- Georgy Litvinov to review (https://github.com/vivo-project/VIVO/issues/3847)
- Review (https://github.com/vivo-project/VIVO/issues/3865)
- Review (https://github.com/vivo-project/VIVO/issues/3864)
- Review (https://github.com/vivo-project/VIVO/issues/3858)
- Review (https://github.com/vivo-project/VIVO/issues/3859)
- Review (https://github.com/vivo-project/VIVO/issues/3855)
- Review (https://github.com/vivo-project/VIVO/security/dependabot/3)
- Brian Lowe and William Welling to review https://github.com/vivo-project/VIVO/pull/3853
- William Welling to review https://github.com/vivo-project/VIVO/pull/3861
- All to think how to organize scripts for VIVO (at the moment for dump and restore) - https://github.com/vivo-project/Vitro/pull/380
- Dragan Ivanovic to make consultation with the VIVO ontology group and Lyrasis system administrators about non-resolvable VIVO ontology links
- Committers to take part in the sprint PR review process
- Dragan Ivanovic to make a PR for fixing privileges for adding grant collaborators
- Brian Lowe to make a PR for fixing ordering of instances with multilingual properties
- Georgy Litvinov will investigate the problem of searching instances with multilingual properties
- Ralph O'Flinn to help with Preparing Documentation for Release by coping space VIVO 1.12.x Documentation to the space VIVO 1.13.x Documentation (or to grant Dragan Ivanovic permissions to do that)
- Dragan Ivanovic to work on documenting new features for VIVO 1.13.x Documentation
- Dragan Ivanovic to create the third one google form for reporting the testing results, that form should be used for testing new features introduced in VIVO 1.13.0
- Everyone to review https://docs.google.com/forms/d/13W2vynR6OmavoV2Px_kJ-k-dlQDv3ERWG0PnXX7ekQA/edit?usp=sharing and https://docs.google.com/forms/d/1dks3b3sJsmM7Q33bwHW_1iVem5VRjg3fqpx8UTFKIfI/edit?usp=sharing
- Brian Lowe to work on removing spring dependencies (https://github.com/vivo-project/VIVO/issues/3686)
- Georgy Litvinov to work on PR for merging back a lost fix he noticed
- Everyone to review spreadsheet for defining requirements for JS and CSS framework selection - https://docs.google.com/spreadsheets/d/1p-86FdqQR2SpFIsK5Xa-k6Dgm5ORg6Lrc7eeOEetm8g/edit?usp=sharing
- Benjamin Gross to review https://github.com/vivo-project/Vitro/pull/251
- Dragan Ivanovic to review https://github.com/vivo-project/Vitro/pull/251
- Georgy Litvinov to fix the issue with GitHub action https://github.com/vivo-project/Vitro/pull/269
- Ralph O'Flinn to review https://github.com/vivo-project/Vitro/pull/269
- William Welling to review https://github.com/vivo-project/Vitro/pull/269
- Georgy Litvinov to update pom versions in https://github.com/vivo-project/VIVO-languages/pull/104 and https://github.com/vivo-project/Vitro-languages/pull/54
- Dragan Ivanovic to review and merge https://github.com/vivo-project/VIVO-languages/pull/104 and https://github.com/vivo-project/Vitro-languages/pull/54
- Georgy Litvinov to review https://github.com/vivo-project/VIVO/pull/3613
- Dragan Ivanovic to review https://github.com/vivo-project/Vitro/pull/240
- Brian Lowe to review https://github.com/vivo-project/Vitro/pull/240
- Ralph O'Flinn to publish orcid-api-client 0.6.4 and update version of this library at https://github.com/vivo-project/VIVO/blob/main/api/pom.xml#L62
- Dragan Ivanovic to create announcement for the demo meeting and to spread it
- Dragan Ivanovic to reorganize code of https://github.com/vivo-project/Vitro/pull/287 and to get rid of enumerations for data types
- Dragan Ivanovic to investigate organizational (management) aspects of DSpace community and to prepare discussion for the next meeting what might be adopted from there (GitHub actions, labels for issues, template for issue, template for PR)
- William Welling Georgy Litvinov to review sprint PRs (there should be three PRs)
- Brian Lowe to review N3Template operation PR (https://github.com/vivo-project/Vitro/pull/286)
- Georgy Litvinov to review/test https://github.com/vivo-project/orcid-api-client/pull/12
- Ralph O'Flinn to merge https://github.com/vivo-project/orcid-api-client/pull/12 and publish orcid-api-client 0.6.4
- Georgy Litvinov to complete https://github.com/vivo-project/Vitro/pull/251
- Ralph O'Flinn to merge https://github.com/vivo-project/VIVO/pull/3611, after that Georgy Litvinov will create a branch for the sprint and move the code from his fork to there
- Ralph O'Flinn to resolve missing i18n directory issue in VIVO 1.12.2 release
- Georgy Litvinov to work on specification for Dynamic API, Dragan Ivanovic to help Georgy on request
- Ralph O'Flinn to resolve missing i18n directory issue in VIVO 1.12.2 release
- Dragan Ivanovic to find some examples for citation of a GitHub repositories (https://github.com/vivo-project/VIVO/pull/247)
- Georgy Litvinov to contact Tatiana Walther for reviewing https://github.com/vivo-project/VIVO-languages/pull/104 and https://github.com/vivo-project/Vitro-languages/pull/54
- Benjamin Gross to review https://github.com/vivo-project/VIVO/pull/250, https://github.com/vivo-project/Vitro/pull/251, and https://github.com/vivo-project/Vitro-languages/pull/56
- Brian Lowe to review https://github.com/vivo-project/Vitro/pull/213, https://github.com/vivo-project/Vitro-languages/pull/44, https://github.com/vivo-project/Vitro/pull/240, and https://github.com/vivo-project/VIVO-languages/pull/103
- William Welling to review https://github.com/vivo-project/Vitro/pull/241
- Huda Khan to review https://github.com/vivo-project/VIVO/pull/247
