...
- PR - Vitro 326 and VIVO 3745
- One line change fixing email example settings
- Publishing the VIVO 1.13.0 release
- Publishing a release candidate 3 for VIVO
- Done. RC for VIVO languages is still on #1, RC-2 for Vitro.
- Testing the release candidate
- for release candidate only new fixes should be tested
- https://github.com/vivo-project/Vitro/pull/321 (Issue/vivo 3606 : add language-specific sorting and label fields to search index)
- https://github.com/vivo-project/Vitro/pull/322/files (fix: use public description in data property template model)
- https://github.com/vivo-project/VIVO/pull/3734 (Privilages for editing grant contributors)
- Another PR https://github.com/vivo-project/Vitro/pull/325 to fix property type for use with reconciliation services
- Dragan considering rolling these changes into RC-3. Not exactly right.. Might create RC-4.
- Question on OpenRefine from Brian
- Should this be on by default?! See example.runtime.properties: https://github.com/vivo-project/VIVO/blob/main/home/src/main/resources/config/example.runtime.properties#L414
- Big question… does this service honor visibility settings?!
- Easily solution is to comment out the defaultTypeList setting
- Perhaps add note to upgrade notes that encourages users to review enabled services in runtime.properties
- VIVO 1.13.0 Technical Documentation
- Wiki space - VIVO 1.13.x Documentation
- Adding of technical documentation for:
- Deletion of individuals
- done
- Installing VIVO
- Release Notes
- Updated by Dragan
- Publishing VIVO 1.13.0
- VIVO-solr
- https://github.com/vivo-project/vivo-solr/pull/6
- Brian suggested rolling vivo-solr back into main VIVO project
- Georgy disagrees. It doesn’t interact with VIVO app at all.
- Also Elasticsearch is an option
- Don’t want to delay new VIVO release with this discussion
- What was the original purpose of separating this out? Similar to VIVO and Vitro languages? Makes it much more difficult to work with source code.
- One argument for separate repo, encourages contributions without ‘scary’ Vitro code
- If we combine, won’t be for this release
- Reviewing old PRs (<2021)
- https://github.com/vivo-project/VIVO-languages/pulls (4)
- https://github.com/vivo-project/Vitro/pulls (10)
- https://github.com/vivo-project/VIVO/pulls (10)
- Proposal - if no response to requests for changes, close a pull request after a certain number of months (5 or 6?)
- How do we review in general language-based PRs when we don’t speak the language? In some cases we just have to trust the PR submitter.
- Brian agrees with Benjamin that closing very old PRs is a good idea… they can always be reopened.
Request from Dragan: review and merge the new PRs ASAP so we can push out a new RC!
Actions
Previous actions
- Dragan Ivanovic to make a PR for fixing privileges for adding grant collaborators
- Brian Lowe to make a PR for fixing ordering of instances with multilingual properties
- Georgy Litvinov will investigate the problem of searching instances with multilingual properties
- Ralph O'Flinn to help with Preparing Documentation for Release by coping space VIVO 1.12.x Documentation to the space VIVO 1.13.x Documentation (or to grant Dragan Ivanovic permissions to do that)
- Dragan Ivanovic to work on documenting new features for VIVO 1.13.x Documentation
- Dragan Ivanovic to create the third one google form for reporting the testing results, that form should be used for testing new features introduced in VIVO 1.13.0
- Everyone to review https://docs.google.com/forms/d/13W2vynR6OmavoV2Px_kJ-k-dlQDv3ERWG0PnXX7ekQA/edit?usp=sharing and https://docs.google.com/forms/d/1dks3b3sJsmM7Q33bwHW_1iVem5VRjg3fqpx8UTFKIfI/edit?usp=sharing
- Brian Lowe to work on removing spring dependencies (https://github.com/vivo-project/VIVO/issues/3686)
- Georgy Litvinov to work on PR for merging back a lost fix he noticed
- Everyone to review spreadsheet for defining requirements for JS and CSS framework selection - https://docs.google.com/spreadsheets/d/1p-86FdqQR2SpFIsK5Xa-k6Dgm5ORg6Lrc7eeOEetm8g/edit?usp=sharing
...